lib: fix some misuse of curlx_convert_wchar_to_UTF8 #8521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curlx_convert_wchar_to_UTF8 must be freed by curlx_unicodefree, but prior to this change some uses mistakenly called free. I've reviewed all other uses of curlx_convert_wchar_to_UTF8 and curlx_convert_UTF8_to_wchar. Ref: curl@1d5d0ae Closes #xxxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curlx_convert_wchar_to_UTF8 must be freed by curlx_unicodefree, but
prior to this change some uses mistakenly called free.
I've reviewed all other uses of curlx_convert_wchar_to_UTF8 and
curlx_convert_UTF8_to_wchar.
Ref: 1d5d0ae
Closes #xxxx
Sort of related: I find it confusing that in non-Unicode builds curlx_convert_UTF8_to_tchar and curlx_convert_tchar_to_UTF8 just duplicate the string in its current encoding, and a while ago I added a comment here but it's still easy to forget. Since the purpose of those functions in non-unicode builds is just to use the current encoding then wouldn't it be better to call them curlx_convert_multibyte_to_tchar and curlx_convert_tchar_to_multibyte?