Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtsp: don't let CSeq error override earlier errors #8525

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Feb 28, 2022

  • When done, if an error has already occurred then don't check the
    sequence numbers for mismatch.

A sequence number may not have been received if an error occurred.

Prior to this change a sequence mismatch error would override earlier
errors. For example, a server that returns nothing would cause error
CURLE_GOT_NOTHING in Curl_http_done which was then overridden by
CURLE_RTSP_CSEQ_ERROR in rtsp_done.

Closes #xxxx


Before:

* multi_done: status: 0 prem: 0 done: 0
* Empty reply from server
* The CSseq of this request 1 did not match the response 0
* The cache now contains 0 members
* Closing connection 0
curl: (85) Empty reply from server

After:

* multi_done: status: 0 prem: 0 done: 0
* Empty reply from server
* The cache now contains 0 members
* Closing connection 0
curl: (52) Empty reply from server

- When done, if an error has already occurred then don't check the
  sequence numbers for mismatch.

A sequence number may not have been received if an error occurred.

Prior to this change a sequence mismatch error would override earlier
errors. For example, a server that returns nothing would cause error
CURLE_GOT_NOTHING in Curl_http_done which was then overridden by
CURLE_RTSP_CSEQ_ERROR in rtsp_done.

Closes #xxxx
@jay jay added the RTSP label Feb 28, 2022
@jay
Copy link
Member Author

@jay jay commented Mar 15, 2022

I can't think of anything going wrong with this but also I don't use the RTSP feature so one more call for comments before I land it.

@jay jay deleted the rtsp_no_override branch Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant