Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back setsockopt path to curlx_nonblock #8562

Closed
wants to merge 1 commit into from

Conversation

donny-dont
Copy link
Contributor

@donny-dont donny-dont commented Mar 8, 2022

The implementation using setsockopt was removed when BeOS support was purged. However this functionality wasn't BeOS specific and HAVE_SETSOCKOPT_SO_NONBLOCK is still present in the codebase.

@bagder
Copy link
Member

@bagder bagder commented Mar 8, 2022

What is it needed for?

@donny-dont
Copy link
Contributor Author

@donny-dont donny-dont commented Mar 8, 2022

this-os

Found the above stopped building after the change when updating to 7.82.0.

The check for HAVE_SETSOCKOPT_SO_NONBLOCK is still in the build code, CMake and autotools, but this was the only place it was used in curl.

@bagder
Copy link
Member

@bagder bagder commented Mar 8, 2022

Why do you avoid to write "Orbis OS", presumably the PlayStation 4 system software? It would help if you'd mention that maybe as a comment in the code, to avoid a future mistake in the similar vein.

Does curl build fine otherwise out of the box for Orbis if this fix is brought back?

@donny-dont
Copy link
Contributor Author

@donny-dont donny-dont commented Mar 9, 2022

Yea so PlayStation 4/5 use cURL and this change makes it so it'll build out of the box.

The implementation using setsockopt was removed when BeOS support was purged. However this functionality wasn't BeOS specific and HAVE_SETSOCKOPT_SO_NONBLOCK is still present in the codebase.
@donny-dont
Copy link
Contributor Author

@donny-dont donny-dont commented Mar 9, 2022

Noted the bit of code is for game consoles.

@bagder
Copy link
Member

@bagder bagder commented Mar 9, 2022

I would still like that comment to mention more exact what OS it is for, but I can add that.

@bagder
Copy link
Member

@bagder bagder commented Mar 9, 2022

Thanks!

@donny-dont donny-dont deleted the setsockopt-nonblock branch Mar 9, 2022
@donny-dont
Copy link
Contributor Author

@donny-dont donny-dont commented Mar 9, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants