Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci: use autoreconf -fi instead buildconf #8596

Closed
wants to merge 12 commits into from
Closed

Ci: use autoreconf -fi instead buildconf #8596

wants to merge 12 commits into from

Conversation

pheiduck
Copy link
Contributor

It should be enough to use autoreconf -fi instead buildconf

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but when doing this change wouldn't it make sense to change at all uses of buildconf in github workflow files? (perhaps even in all CI config files)

$ git grep -l buildconf
workflows/linux-hyper.yml
workflows/macos.yml
workflows/mbedtls.yml
workflows/nss.yml
workflows/rustls.yml
workflows/wolfssl.yml

@bagder bagder added the CI Continuous Integration label Mar 15, 2022
@pheiduck
Copy link
Contributor Author

Agreed, but when doing this change wouldn't it make sense to change at all uses of buildconf in github workflow files? (perhaps even in all CI config files)

Saw that I missed some of it, I'm on it ;)

@pheiduck pheiduck requested a review from bagder Mar 15, 2022
bagder
bagder approved these changes Mar 15, 2022
@bagder
Copy link
Member

bagder commented Mar 15, 2022

Thanks!

@bagder bagder closed this in 22d3395 Mar 15, 2022
@pheiduck pheiduck deleted the ci/use_autoreconf branch Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants