Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some Spellcheck/fixes discoverd by lift #8616

Closed
wants to merge 25 commits into from
Closed

some Spellcheck/fixes discoverd by lift #8616

wants to merge 25 commits into from

Conversation

pheiduck
Copy link
Contributor

@pheiduck pheiduck commented Mar 20, 2022

No description provided.

@pheiduck pheiduck changed the title Spellcheck/fixes in lib/firefox-db2pem.sh discoverd by lift some Spellcheck/fixes discoverd by lift Mar 20, 2022
packages/OS400/initscript.sh Outdated Show resolved Hide resolved
packages/OS400/initscript.sh Outdated Show resolved Hide resolved
packages/OS400/makefile.sh Outdated Show resolved Hide resolved
packages/OS400/initscript.sh Outdated Show resolved Hide resolved
packages/OS400/initscript.sh Outdated Show resolved Hide resolved
packages/OS400/makefile.sh Outdated Show resolved Hide resolved
packages/OS400/makefile.sh Outdated Show resolved Hide resolved
packages/OS400/makefile.sh Outdated Show resolved Hide resolved
@pheiduck pheiduck marked this pull request as draft Mar 21, 2022
@pheiduck pheiduck marked this pull request as ready for review Mar 21, 2022
@monnerat
Copy link
Contributor

@monnerat monnerat commented Mar 21, 2022

I totally disagree with the OS400 scripts changes: we are dealing with i5 qshell scripts and not bash scripts: the $(...) syntax is not recognized.
In addition, the setenv() procedure semantics is altered and the result is not what we expect.
Better leave off lift for IBM i5 !

@pheiduck pheiduck closed this Mar 21, 2022
@pheiduck pheiduck deleted the spellcheck/fixes branch Mar 21, 2022
bagder pushed a commit that referenced this issue Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants