New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rewording #865

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@m6w6
Contributor

m6w6 commented Jun 7, 2016

Seems like a phrase was about to be replaced with another one, but only the addition made it in, not the removal.

Fix rewording
Seems like a phrase was about to be replaced with another one, but only the addition made it in, not the removal.
@mention-bot

This comment has been minimized.

mention-bot commented Jun 7, 2016

By analyzing the blame information on this pull request, we identified @bagder, @TheCount and @yangtse to be potential reviewers

@jay

This comment has been minimized.

Member

jay commented Jun 7, 2016

I agree with what you're trying to do here but it is still not technically correct. The integer doesn't point to the number. It would probably be better understood if we were colloquial like 'running_handles receives the number of running easy handles' or something simple like that.

@jay jay closed this in 9295205 Jun 9, 2016

@jay

This comment has been minimized.

Member

jay commented Jun 9, 2016

Thanks, it landed as: "At return, running_handles points to the number of running easy handles within the multi handle."

@m6w6 m6w6 deleted the m6w6:patch-4 branch Jun 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment