Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix rewording #865
Conversation
Seems like a phrase was about to be replaced with another one, but only the addition made it in, not the removal.
This comment has been minimized.
This comment has been minimized.
mention-bot
commented
Jun 7, 2016
This comment has been minimized.
This comment has been minimized.
|
I agree with what you're trying to do here but it is still not technically correct. The integer doesn't point to the number. It would probably be better understood if we were colloquial like 'running_handles receives the number of running easy handles' or something simple like that. |
This comment has been minimized.
This comment has been minimized.
|
Thanks, it landed as: "At return, running_handles points to the number of running easy handles within the multi handle." |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
m6w6 commentedJun 7, 2016
Seems like a phrase was about to be replaced with another one, but only the addition made it in, not the removal.