Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opts: deprecate RANDOM_FILE and EGDSOCKET #8670

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Apr 4, 2022

These two options were only ever used for the OpenSSL backend for
versions before 1.1.0. They were never used for other backends and they
are not used with recent OpenSSL versions. They were never used much by
applications.

The defines RANDOM_FILE and EGD_SOCKET can still be set at build-time
for ancient EOL OpenSSL versions.

@jay
Copy link
Member

@jay jay commented Apr 4, 2022

Deprecated option. Serves no purpose anymore.

IMO this is unclear. deprecated means still supported but going to be removed eventually. while that may be true of the option's name it's not true of the option's function which has been removed. "Deprecated option. This option has no effect since 7.83.0." Also explain it can still be set at build time or document that somewhere else, eg "It can still be set at build time using define EGD_SOCKET."

After rereading this it looks like you are saying any recent OpenSSL it has no effect so probably clearer as "Deprecated option. This option is ignored by curl since 7.83.0. Prior to that it only had an effect on old versions of OpenSSL."

@bagder
Copy link
Member Author

@bagder bagder commented Apr 4, 2022

This option is ignored by curl since 7.83.0.

The AVAILABILITY section in the bottom has the exact version information.

Prior to that it only had an effect on old versions of OpenSSL

I'll see how I can get that info added to the page.

@jay
Copy link
Member

@jay jay commented Apr 5, 2022

The AVAILABILITY section in the bottom has the exact version information.

I was referring to the curl tool options

@bagder
Copy link
Member Author

@bagder bagder commented Apr 5, 2022

aha

bagder added 2 commits May 16, 2022
These two options were only ever used for the OpenSSL backend for
versions before 1.1.0. They were never used for other backends and they
are not used with recent OpenSSL versions. They were never used much by
applications.

The defines RANDOM_FILE and EGD_SOCKET can still be set at build-time
for ancient EOL OpenSSL versions.
As libcurl no longer has any functionality for them, the toll now does
nothing with them.
@bagder bagder force-pushed the bagder/random-file-egd-socket branch from 55b97aa to 7e51da3 Compare May 16, 2022
@bagder bagder closed this in 8d86718 May 17, 2022
bagder added a commit that referenced this issue May 17, 2022
As libcurl no longer has any functionality for them, the tool now does
nothing with them.

Closes #8670
@bagder bagder deleted the bagder/random-file-egd-socket branch May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants