Closed
Conversation
|
By analyzing the blame information on this pull request, we identified @jzakrzewski, @captain-caveman2k and @billhoffman to be potential reviewers |
Contributor
Author
|
@bradking Could you please review? |
Contributor
Author
Contributor
|
LGTM. The change is quite small when viewed without whitespace changes. |
Contributor
Author
|
Yes. Just inversed condition. |
jay
pushed a commit
that referenced
this pull request
Jun 15, 2016
Bug: #874 Reported-by: Sergei Nikulov
Member
|
Thanks, landed in b70ca52. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed cmake script to correctly enable LDAP protocol with cmake on Windows.
Current implementation set CURL_DISABLE_LDAP even if USE_WIN32_LDAP enabled.