New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake // fix build with winldap #874

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@snikulov
Member

snikulov commented Jun 14, 2016

Fixed cmake script to correctly enable LDAP protocol with cmake on Windows.
Current implementation set CURL_DISABLE_LDAP even if USE_WIN32_LDAP enabled.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jun 14, 2016

By analyzing the blame information on this pull request, we identified @jzakrzewski, @captain-caveman2k and @billhoffman to be potential reviewers

mention-bot commented Jun 14, 2016

By analyzing the blame information on this pull request, we identified @jzakrzewski, @captain-caveman2k and @billhoffman to be potential reviewers

@snikulov

This comment has been minimized.

Show comment
Hide comment
@snikulov

snikulov Jun 14, 2016

Member

@bradking Could you please review?

Member

snikulov commented Jun 14, 2016

@bradking Could you please review?

@snikulov

This comment has been minimized.

Show comment
Hide comment
@snikulov

snikulov Jun 14, 2016

Member

@bagder BTW, master branch build for Mac was broken with following commit 9b6d3a6

Test 2050 is failing constantly since then. You can check it with history

Member

snikulov commented Jun 14, 2016

@bagder BTW, master branch build for Mac was broken with following commit 9b6d3a6

Test 2050 is failing constantly since then. You can check it with history

@bradking

This comment has been minimized.

Show comment
Hide comment
@bradking

bradking Jun 15, 2016

Contributor

LGTM.

The change is quite small when viewed without whitespace changes.

Contributor

bradking commented Jun 15, 2016

LGTM.

The change is quite small when viewed without whitespace changes.

@snikulov

This comment has been minimized.

Show comment
Hide comment
@snikulov

snikulov Jun 15, 2016

Member

Yes. Just inversed condition.

Member

snikulov commented Jun 15, 2016

Yes. Just inversed condition.

jay added a commit that referenced this pull request Jun 15, 2016

cmake: Fix build with winldap
Bug: #874
Reported-by: Sergei Nikulov
@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Jun 15, 2016

Member

Thanks, landed in b70ca52.

Member

jay commented Jun 15, 2016

Thanks, landed in b70ca52.

@jay jay closed this Jun 15, 2016

@snikulov snikulov deleted the snikulov:fix_cmake_winldap branch Jun 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment