Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake // fix build with winldap #874

Closed
wants to merge 1 commit into from

Conversation

snikulov
Copy link
Member

Fixed cmake script to correctly enable LDAP protocol with cmake on Windows.
Current implementation set CURL_DISABLE_LDAP even if USE_WIN32_LDAP enabled.

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @jzakrzewski, @captain-caveman2k and @billhoffman to be potential reviewers

@snikulov
Copy link
Member Author

@bradking Could you please review?

@snikulov
Copy link
Member Author

snikulov commented Jun 14, 2016

@bagder BTW, master branch build for Mac was broken with following commit 9b6d3a6

Test 2050 is failing constantly since then. You can check it with history

@bradking
Copy link
Contributor

LGTM.

The change is quite small when viewed without whitespace changes.

@snikulov
Copy link
Member Author

Yes. Just inversed condition.

jay pushed a commit that referenced this pull request Jun 15, 2016
Bug: #874
Reported-by: Sergei Nikulov
@jay
Copy link
Member

jay commented Jun 15, 2016

Thanks, landed in b70ca52.

@jay jay closed this Jun 15, 2016
@snikulov snikulov deleted the fix_cmake_winldap branch June 15, 2016 20:32
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants