Pass remote_port to MsH3ConnectionOpen #8762
Conversation
lib/vquic/msh3.c
Outdated
| @@ -95,7 +95,7 @@ static const MSH3_REQUEST_IF msh3_request_if = { | |||
|
|
|||
| void Curl_quic_ver(char *p, size_t len) | |||
| { | |||
| (void)msnprintf(p, len, "msh3/%s", "0.0.1"); | |||
| (void)msnprintf(p, len, "msh3/%s", "0.3.0"); | |||
There was a problem hiding this comment.
This seems brittle, can we persuade the good msh3 folks to add version information to msh3.h which we can consume?
There was a problem hiding this comment.
I agree! That's why I created nibanks/msh3#23. Feel free to take a crack at it.
There was a problem hiding this comment.
RIght. it's useful if version string API in mash3. @nibanks What do you think about?
There was a problem hiding this comment.
As nibanks/msh3#38 has been merged now, this can now get the runtime version!
There was a problem hiding this comment.
Ok! I'll try to it.
| qs->conn = MsH3ConnectionOpen(qs->api, | ||
| conn->host.name, | ||
| (uint16_t)conn->remote_port, | ||
| unsecure); |
There was a problem hiding this comment.
This will put a hard requirement on a very recent version of the library, that should go into the --with-msh3 autoconf check to test for this signature no?
There was a problem hiding this comment.
I think it's very safe if there is a signature checking, but too early to introduce it probably.
There was a problem hiding this comment.
I think for now it is fine to require a very recent version of msh3 to build. It is early days and I assume it might move a bit going forward. We've worked similar to that with the other h3 libraries. They're all "beta" and this is functionality still labeled "experimental" in curl.
|
It is unlikely that I will be able to get this to pass all the tests... |
I'm afraid you see a lot of unrelated flaky CI build failures right now. They're not happening because of anything in this PR. |
MsH3 supported additional "Port" parameter to connect not hosted on 443 port QUIC website. * https://github.com/nibanks/msh3/releases/tag/v0.3.0 * nibanks/msh3#37
|
Thanks! |
What
MsH3 supported additional "Port" parameter to connect not hosted on 443 port QUIC website.