Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "make ca-firefox" #8804

Closed
wants to merge 1 commit into from
Closed

Fix "make ca-firefox" #8804

wants to merge 1 commit into from

Conversation

ryandesign
Copy link
Contributor

@ryandesign ryandesign commented May 5, 2022

With curl 7.83.0, make ca-firefox fails with:

make: *** No rule to make target `lib/firefox-db2pem.sh', needed by `ca-firefox'.  Stop.

firefox-db2pem.sh was moved from lib to scritps.

After fixing the paths in the Makefile it fails with:

generate a fresh ca-bundle.crt
scripts/firefox-db2pem.sh lib/ca-bundle.crt
make: scripts/firefox-db2pem.sh: Permission denied
make: *** [ca-firefox] Error 1

That's fixed with a further chmod a+x.

bagder
bagder approved these changes May 5, 2022
Copy link
Member

@bagder bagder left a comment

Would it perhaps be better to run the script with sh to not rely on +x ?

@ryandesign
Copy link
Contributor Author

@ryandesign ryandesign commented May 5, 2022

Up to you! All of the other scripts in the scripts directory, except installcheck.sh, already have the execute bit.

@bagder
Copy link
Member

@bagder bagder commented May 5, 2022

Ah right, so let's keep it for consistency

@bagder
Copy link
Member

@bagder bagder commented May 5, 2022

Thanks!

@ryandesign ryandesign deleted the ca-firefox branch May 5, 2022
@jay jay added the script label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants