Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: always debug print stream id in decimal #8808

wants to merge 1 commit into from


Copy link

Sometimes the stream id is printed with %x and sometimes with %d or %u. Confusing.

Copy link

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using %u instead? It seems a lot of places already use that, so it would make it even more consistent.

Copy link
Contributor Author

Hmm. Sometimes %d is used and sometimes %u. Data type is int32_t, so %d seemed to be more appropriate for me. Maybe I should change all stream id printf to either %u or %d. Just let me know what you prefer.

Copy link

bagder commented May 9, 2022

Streams are identified with an unsigned 31-bit integer, so it doesn't matter which type we use. They are still unsigned. I think using %u makes that clearer in the code.

Copy link

jay commented May 12, 2022


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

3 participants