cmake // Added Ctest support for unittests

[snikulov]

Hi all,
I've enabled ctest verification for cmake builds and tests/unit folder.
Now it is possible after build run
on Linux
make test
on Windows
ctest -VV -C <Debug|Release>

[mention-bot]

By analyzing the blame information on this pull request, we identified @billhoffman, @Sukender and @Lekensteyn to be potential reviewers

[snikulov]

@bradking Brad, could you please review and comment? Thank you!

[bradking]

The CTest module calls enable_testing for us so we don't need to call it here.

[snikulov]

@bradking From which version? Looks I'm a bit outdated here.

[bradking]

It has always done this.

[bradking]

Note that it depends on BUILD_TESTING.

[snikulov]

@bradking updated and rebased into single commit.

[bradking]

The CTest module defines a BUILD_TESTING option that controls most of its functionality, including its call to enable_testing. The intended way to use the CTest module is to include it unconditionally and then honor its BUILD_TESTING option:

include(CTest)
if(BUILD_TESTING)
  add_subdirectory(tests)
endif()

However, curl is currently defining its own BUILD_CURL_TESTS option. It also has a code path that includes the CTest module earlier in a BUILD_DASHBOARD_REPORTS condition. These should all be reconciled.

[snikulov]

@bradking So what is your proposal, exactly? Should I remove BUILD_CURL_TESTS and BUILD_DASHBOARD_REPORTS anywhere in scripts?

[bradking]

Should I remove BUILD_CURL_TESTS and BUILD_DASHBOARD_REPORTS anywhere in scripts?

That would be the simplest solution. Since the CMake files still warn that they are poorly maintained I don't think anyone expects stability in the current options.

[snikulov]

@bradking updated.

[bradking]

The change itself looks good. Please squash in the fixups and revise the commit message to explain the new logic change.

[snikulov]

@bradking Done.

@bagder Daniel, Could you please merge?

[bagder]

Done, thanks!

Small nit: please make the commit message to follow our commit styles and I'll have an easier job merging your work!