Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the HTTP writedelay unit to milliseconds #8827

Closed

Conversation

fabiankeil
Copy link
Contributor

@fabiankeil fabiankeil commented May 9, 2022

This allows to use write delays for large responses without
resulting in the test taking an unreasonable amount of time.

In many cases delaying writes by a whole second or more isn't
necessary for the desired effect.

fabiankeil added 4 commits May 9, 2022
This allows to use write delays for large responses without
resulting in the test taking an unreasonable amount of time.

In many cases delaying writes by a whole second or more isn't
necessary for the desired effect.
... so the delays are the same now that the unit
is in milliseconds.
This makes it more likely that the trailer is received
seperately from the last-chunk.

curl doesn't seem to care about this but it makes the tests
more useful when testing external proxies like Privoxy.
bagder
bagder approved these changes May 9, 2022
@bagder
Copy link
Member

@bagder bagder commented May 11, 2022

Thanks!

@bagder bagder closed this in fc3a0a8 May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants