also check %USERPROFILE% variable to find .netrc file on Windows

[wolfv]

It seems that %HOME% isn't always set on Windows.
However, %USERPROFILE% seems to be a standard variable on Windows. So I just added another branch of the if condition to look in there for the .netrc file if %HOME% is not set.

Ref: mamba-org/mamba#870

[bagder]

It is already done/attempted here:

curl/src/tool_findfile.c

Line 55 in bda0d5f

{ "USERPROFILE", NULL, FALSE },

So why isn't that working already?

[wolfv]

correct me if I am wrong, but it doesn't look like the findfile function is used in the netrc code?

Should we change the code to something like:

int Curl_parsenetrc(const char *host,
                    char **loginp,
                    char **passwordp,
                    bool *login_changed,
                    bool *password_changed,
                    char *netrcfile)
{
  int retcode = 1;

  if(!netrcfile) {
    netrcfile = findfile("netrc", TRUE);

    if(!netrcfile)
      return retcode; /* no home directory found (or possibly out of
                         memory) */

    retcode = parsenetrc(host, loginp, passwordp, login_changed,
                         password_changed, netrcfile);
    free(netrcfile);
  }
  else
    retcode = parsenetrc(host, loginp, passwordp, login_changed,
                         password_changed, netrcfile);
  return retcode;
}

[bagder]

but it doesn't look like the findfile

blah, but of course... 😕

[wolfv]

@bagder not sure I understand your preferred fix for this. I guess it wouldn't be fine to depend on tool_findfile.h since that's not part of libcurl, right? Would be nice to re-use the findfile functions logic though.

Please let me know what you think. Happy to attempt an implementation & fix.

[bagder]

This also needs a documentation update!

[bagder]

shouldn't this rather check for plain WIN32 ?

[wolfv]

changed that! thanks

[bagder]

Thanks!