Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headers api: remove EXPERIMENTAL tag #8900

Closed
wants to merge 3 commits into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented May 24, 2022

No description provided.

@bagder
Copy link
Member Author

@bagder bagder commented May 24, 2022

A complete lack of feedback, but I feel fairly confident this is good enough.

@bagder bagder force-pushed the bagder/headers-api-unexperiment branch from 15b4c0f to eb1cb89 Compare May 24, 2022
@xquery
Copy link
Member

@xquery xquery commented May 24, 2022

FWIW I have played with it a bit - at least the 'happy paths' seem robust enough

bagder added a commit that referenced this issue May 25, 2022
@bagder bagder force-pushed the bagder/headers-api-unexperiment branch from eb1cb89 to 4a7359b Compare May 25, 2022
bagder added a commit that referenced this issue May 25, 2022
@bagder bagder force-pushed the bagder/headers-api-unexperiment branch from 4a7359b to 78e04d5 Compare May 25, 2022
@mback2k
Copy link
Member

@mback2k mback2k commented May 25, 2022

Somewhat related note: test 1940 is consistently broken on the Cirrus CI Windows builds due to invalid line endings. Maybe something is written with the wrong mode there?

Generally speaking: IMHO Windows CI stability is now at a point there it makes sense to always review failures instead of ignoring them without looking at all and thinking the flakiness is the cause. 😉

@bagder
Copy link
Member Author

@bagder bagder commented May 25, 2022

I've seen it, but the test runs fine on appveyor builds. The line endings should be fine as the section is marked as text. I don't know why it happens.

@bagder bagder force-pushed the bagder/headers-api-unexperiment branch from 78e04d5 to 7633ccd Compare May 30, 2022
@bagder bagder closed this in 4d94fac May 30, 2022
@bagder bagder deleted the bagder/headers-api-unexperiment branch May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants