Makefile.m32: delete obsolete options, improve -On [ci skip] #8904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
force-pushed
the
m32clean3
branch
2 times, most recently
from
52b4b6f to
7f98ad7
Compare
vszakats
changed the title
vszakats
changed the title
- `-D_AMD64_` has not been necessary for mingw-w64 builds for a long time now. - `-fno-strict-aliasing` is mentioned for Intel C compiler in autotools, and I used this with VxWorks in another project, but otherwise this isn't necessary anymore as a default. If a target still needs it, it can be added with `CURL_CFLAG_EXTRAS=-fno-strict-aliasing` - bump up default optimization level to `-O3` (from `-O2`), and also rearrange option order so the default can now be overridden via `CURL_CFLAG_EXTRAS`. - delete `-g` (generate debug info) from `CFLAGS` and `-s` from `LDFLAGS` (strip debug info). They were working against each other. Now, if someone needs debug info, it can be enabled via `CURL_CFLAG_EXTRAS=-g`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-D_AMD64_has not been necessary for mingw-w64 builds for a long time now.-fno-strict-aliasingis mentioned for Intel C compiler in autotools, andI used this with VxWorks in another project, but otherwise this isn't
necessary anymore as a default. If a target still needs it, it can be
added with
CURL_CFLAG_EXTRAS=-fno-strict-aliasing-O3(from-O2), and also rearrangeoption order so the default can now be overridden via
CURL_CFLAG_EXTRAS.-g(generate debug info) fromCFLAGSand-sfromLDFLAGS(strip debug info). They were working against each other. Now, if someone
needs debug info, it can be enabled via
CURL_CFLAG_EXTRAS=-g