Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.m32: delete obsolete options, improve -On [ci skip] #8904

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented May 24, 2022

  • -D_AMD64_ has not been necessary for mingw-w64 builds for a long time now.
  • -fno-strict-aliasing is mentioned for Intel C compiler in autotools, and
    I used this with VxWorks in another project, but otherwise this isn't
    necessary anymore as a default. If a target still needs it, it can be
    added with CURL_CFLAG_EXTRAS=-fno-strict-aliasing
  • bump up default optimization level to -O3 (from -O2), and also rearrange
    option order so the default can now be overridden via
    CURL_CFLAG_EXTRAS.
  • delete -g (generate debug info) from CFLAGS and -s from LDFLAGS
    (strip debug info). They were working against each other. Now, if someone
    needs debug info, it can be enabled via CURL_CFLAG_EXTRAS=-g

@vszakats vszakats force-pushed the m32clean3 branch 2 times, most recently from 52b4b6f to 7f98ad7 Compare May 24, 2022
@vszakats vszakats changed the title Makefile.m32: delete -D_AMD64_ and -fno-strict-aliasing [ci skip] Makefile.m32: delete -D_AMD64_, -fno-strict-aliasing, improve -On [ci skip] May 24, 2022
@vszakats vszakats changed the title Makefile.m32: delete -D_AMD64_, -fno-strict-aliasing, improve -On [ci skip] Makefile.m32: delete obsolete options, improve -On [ci skip] May 24, 2022
- `-D_AMD64_` has not been necessary for mingw-w64 builds for a long time now.
- `-fno-strict-aliasing` is mentioned for Intel C compiler in autotools, and
  I used this with VxWorks in another project, but otherwise this isn't
  necessary anymore as a default. If a target still needs it, it can be
  added with `CURL_CFLAG_EXTRAS=-fno-strict-aliasing`
- bump up default optimization level to `-O3` (from `-O2`), and also rearrange
  option order so the default can now be overridden via
  `CURL_CFLAG_EXTRAS`.
- delete `-g` (generate debug info) from `CFLAGS` and `-s` from `LDFLAGS`
  (strip debug info). They were working against each other. Now, if someone
  needs debug info, it can be enabled via `CURL_CFLAG_EXTRAS=-g`
@vszakats vszakats closed this in 16a58e9 May 24, 2022
@vszakats vszakats deleted the m32clean3 branch May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant