docs/CONTRIBUTE.md: document the 'needs-votes' concept #8910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pull request sent to the project might get labeled `needs-votes` by a project maintainer. This label means that in addition to meeting all other checks and qualifications this pull request must also receive at least **5** thumbs-up reactions on GitHub to be considered for merging.
Member
|
I'd rather we not box ourselves in and I think the informal process we have now works well. 5 users (user thumbs) could think anything is a good idea. I would leave any voting to collaborators, and only when it's really needed. If you really want to tag them I think needs-more-feedback or something, which we already say. I will follow up in the list thread. |
Member
Author
|
Tagging doesn't work as I/we don't know who to tag. I think 4 or 5 of the pending PRs we have now are such pull requests. Virtually no one but the author and me have interacted in them and I don't know if these are changes we actually want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pull request sent to the project might get labeled
needs-votesby aproject maintainer. This label means that in addition to meeting all
other checks and qualifications this pull request must also receive at
least 5 thumbs-up reactions on GitHub to be considered for merging.
Discussed: https://curl.se/mail/lib-2022-05/0067.html