Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/CONTRIBUTE.md: document the 'needs-votes' concept #8910

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented May 24, 2022

A pull request sent to the project might get labeled needs-votes by a
project maintainer. This label means that in addition to meeting all
other checks and qualifications this pull request must also receive at
least 5 thumbs-up reactions on GitHub to be considered for merging.

Discussed: https://curl.se/mail/lib-2022-05/0067.html

A pull request sent to the project might get labeled `needs-votes` by a
project maintainer. This label means that in addition to meeting all
other checks and qualifications this pull request must also receive at
least **5** thumbs-up reactions on GitHub to be considered for merging.
@jay
Copy link
Member

@jay jay commented May 25, 2022

I'd rather we not box ourselves in and I think the informal process we have now works well. 5 users (user thumbs) could think anything is a good idea. I would leave any voting to collaborators, and only when it's really needed. If you really want to tag them I think needs-more-feedback or something, which we already say. I will follow up in the list thread.

@bagder
Copy link
Member Author

@bagder bagder commented May 25, 2022

Tagging doesn't work as I/we don't know who to tag. I think 4 or 5 of the pending PRs we have now are such pull requests. Virtually no one but the author and me have interacted in them and I don't know if these are changes we actually want.

@bagder bagder closed this in 267d560 Jun 2, 2022
@bagder bagder deleted the bagder/needs-votes branch Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants