Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: enable curl.rc for all Windows targets #8918

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented May 25, 2022

Before this patch, it was only enabled for MSVC. This syncs this
configuration with libcurl.rc, which was already included for all
Windows targets.

Before this patch, it was only enabled for MSVC. This syncs this
configuration with libcurl.rc, which was already included for all
Windows targets.
vszakats added a commit to curl/curl-for-win that referenced this issue May 25, 2022
These are upstream issues, with these PRs:
- curl/curl#8918
- curl/curl#8917
@vszakats vszakats added build cmake Windows labels May 25, 2022
@Karlson2k
Copy link
Contributor

@Karlson2k Karlson2k commented May 26, 2022

Will curl.rc be used for static version as well with this patch?
It must be used only for .DLL.

@vszakats
Copy link
Member Author

@vszakats vszakats commented May 26, 2022

@Karlson2k This enables curl.rc for curl.exe, either when it is linked against a static libcurl or libcurl.dll.

@vszakats
Copy link
Member Author

@vszakats vszakats commented May 26, 2022

However, libcurl.rc is at the moment added to both libcurl.dll and static libcurl library, of which the latter is indeed wrong. PR opened.

@vszakats vszakats closed this in 2e76976 May 26, 2022
vszakats added a commit that referenced this issue May 26, 2022
Fixes: #8918 (comment)

Reviewed-By: Karlson2k@users.noreply.github.com
Closes #8923
@vszakats vszakats deleted the cmake-src-rc branch May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants