Skip to content

struct UserDefined cleanups #8940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

struct UserDefined cleanups #8940

wants to merge 3 commits into from

Conversation

@bagder
Copy link
Member

@bagder bagder commented May 31, 2022

  • reduce variable sizes
  • remove unused fields

@bagder bagder added the tidy-up label May 31, 2022
bagder added 3 commits May 31, 2022 13:42
@bagder
urldata: remove three unused booleans from struct UserDefined
3cce0a8 
- is_fwrite_set
- free_referer
- strip_path_slash

Closes #8940
@bagder
urldata: reduce size of a few struct fields
a2567f2 
When the values are never larger than 32 bit, ints are better than longs.

Closes #8940
@bagder
urldata: store tcp_keepidle and tcp_keepintvl as ints
6584d5c 
They can't be set larger than INT_MAX in the setsocket API calls.

Also document the max values in their respective man pages.

Closes #8940
@bagder bagder force-pushed the bagder/is_fwrite_set branch from b66f48e to 6584d5c Compare May 31, 2022 11:42
@bagder bagder closed this in b1c1df0 Jun 1, 2022
bagder added a commit that referenced this pull request Jun 1, 2022
@bagder
urldata: reduce size of a few struct fields
4651945 
When the values are never larger than 32 bit, ints are better than longs.

Closes #8940
bagder added a commit that referenced this pull request Jun 1, 2022
@bagder
urldata: store tcp_keepidle and tcp_keepintvl as ints
8b1ae28 
They can't be set larger than INT_MAX in the setsocket API calls.

Also document the max values in their respective man pages.

Closes #8940
@bagder bagder deleted the bagder/is_fwrite_set branch June 1, 2022 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tidy-up

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bagder