Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor test improvements #8959

Closed
wants to merge 5 commits into from

Conversation

fabiankeil
Copy link
Contributor

This PR fixes a couple of minor issues I noticed while running the tests with Privoxy as proxy.

... so the test works when using a HTTP proxy like
Privoxy that sends an error message if the server
doesn't send data.
... so the tests can be automatically skipped when
using an external proxy like Privoxy.
... so the test can be automatically skipped when
using an external proxy like Privoxy.
Copy link

@mehmetbybz mehmetbybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files changed

@bagder bagder added the tests label Jun 5, 2022
bagder
bagder approved these changes Jun 6, 2022
@bagder bagder closed this in 9dfa1dc Jun 6, 2022
bagder pushed a commit that referenced this pull request Jun 6, 2022
... so the test works when using a HTTP proxy like
Privoxy that sends an error message if the server
doesn't send data.

Closes #8959
bagder pushed a commit that referenced this pull request Jun 6, 2022
bagder pushed a commit that referenced this pull request Jun 6, 2022
... so the tests can be automatically skipped when
using an external proxy like Privoxy.

Closes #8959
bagder pushed a commit that referenced this pull request Jun 6, 2022
... so the test can be automatically skipped when
using an external proxy like Privoxy.

Closes #8959
@bagder
Copy link
Member

bagder commented Jun 6, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants