-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor test improvements #8959
Closed
Closed
Minor test improvements #8959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so the test works when using a HTTP proxy like Privoxy that sends an error message if the server doesn't send data.
... so the tests can be automatically skipped when using an external proxy like Privoxy.
... so the test can be automatically skipped when using an external proxy like Privoxy.
mehmetbybz
reviewed
Jun 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files changed
bagder
approved these changes
Jun 6, 2022
bagder
pushed a commit
that referenced
this pull request
Jun 6, 2022
... so the test works when using a HTTP proxy like Privoxy that sends an error message if the server doesn't send data. Closes #8959
bagder
pushed a commit
that referenced
this pull request
Jun 6, 2022
bagder
pushed a commit
that referenced
this pull request
Jun 6, 2022
... so the tests can be automatically skipped when using an external proxy like Privoxy. Closes #8959
bagder
pushed a commit
that referenced
this pull request
Jun 6, 2022
... so the test can be automatically skipped when using an external proxy like Privoxy. Closes #8959
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of minor issues I noticed while running the tests with Privoxy as proxy.