-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setopt: add CURLOPT_PROTOCOLS_STR and CURLOPT_REDIR_PROTOCOLS_STR #8992
Conversation
Wouldn't a curl_slist of strings instead of a single string be more useful? It would be easier to parse and probably faster, too. |
Faster to parse, but perhaps a bit more inconvenient to create? |
On Mon, Jun 13, 2022 at 02:14:13AM -0700, Daniel Stenberg wrote:
+instensitive protocol names (URL schemes) to allow in the transfer. This
Typo here, too: insensitive
|
Thanks! I fixed both of them actually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in commit message: CURLINFO_PROTOL
Do the protocols accepted by CURLOPT_PROTOCOLS_STR exactly match the ones supplied by curl_version_info()? There should probably be a reference to that function in this man page as being the way to retrieve all allowed protocols. |
... as replacements for deprecated CURLOPT_PROTOCOLS and CURLOPT_REDIR_PROTOCOLS as these new ones do not risk running into the 32 bit limit the old ones are facing. CURLINFO_PROTCOOL is now deprecated. The curl tool is updated to use the new options. Added test 1597 to verify the libcurl protocol parser. Closes #8992
Fixed locally now.
Yes - all protocols
Good idea. I'll amend! |
... as replacements for deprecated CURLOPT_PROTOCOLS and
CURLOPT_REDIR_PROTOCOLS as these new ones do not risk running into the
32 bit limit the old ones are facing.
CURLINFO_PROTOL is now deprecated.
The curl tool is updated to use the new options.