-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test3026: add support for Windows using native Win32 threads #9012
Conversation
c750e3f
to
d2510b4
Compare
d2510b4
to
959c490
Compare
It seems like the threadsafe init is broken on 32-Bit Windows. |
All the CI failures I see are errno 8 (ERROR_NOT_ENOUGH_MEMORY). Creating 1000 test threads is probably too many. Which CI are you referring to? You could try changing the stack size? Also I think on error it should say GetLastError instead of errno since it's actually an error code from the former. |
If that is a problem, we can probably consider it tested with 100 too... |
Yeah, I will try to reduce the number of threads in case a 32-bit build is done. |
Follow-up to recent commits which added thread-safety support. Bug: #9012 (comment) Reported-by: Marc Hörsken Closes #xxxx
Follow-up to recent commits which added thread-safety support. Bug: #9012 (comment) Reported-by: Marc Hörsken Closes #9030
959c490
to
53fdb2e
Compare
53fdb2e
to
40a74f3
Compare
Also make sure the result is initialized to an invalid value (
CURL_LAST
) before the corresponding thread is launched.Follow up to #8996