Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtests: skip starting the ssh server if user name is lacking #9013

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jun 14, 2022

Because the ssh server startup script requires a user name there's no
point in invoking it if no name was found.

Reported-by: Ricardo M. Correia
Fixes #9007

Because the ssh server startup script *requires* a user name there's no
point in invoking it if no name was found.

Reported-by: Ricardo M. Correia
Fixes #9007
@wizeman
Copy link

@wizeman wizeman commented Jun 14, 2022

Fixes #9007

I don't understand, you're saying that this fixes #9007, but what does the ssh server has to do with the test 587 failure I've reported in #9007?

Test 587's script has code such as:

<server>
http
</server>
<name>
HTTP multi-part formpost with aborted read callback
 </name>
 <command>
http://%HOSTIP:%HTTPPORT/%TESTNUMBER
</command>

... and the protocol section also seems to be an HTTP POST request.

So it just seems to be an HTTP test, and nothing to do with SSH or SFTP?

I'm not saying it's not worthwhile to fix this SSH issue, I'm just saying that it doesn't seem like it will fix #9007?

@bagder
Copy link
Member Author

@bagder bagder commented Jun 14, 2022

Let's not discuss #9007 in #9013, especially not if this is not a fix for it

@wizeman
Copy link

@wizeman wizeman commented Jun 14, 2022

Let's not discuss #9007 in #9013, especially not if this is not a fix for it

I believe I was discussing #9013, specifically this part of the commit message (which I quoted on the first line of my comment):

Fixes #9007

If you don't remove that line from the commit message of this PR, then when/if this PR is merged, Github will close #9007 automatically, despite this PR not being a fix for #9007.

@bagder bagder closed this in f0f587d Jun 15, 2022
@bagder bagder deleted the bagder/runtests-user-sshserver branch Jun 15, 2022
@bagder
Copy link
Member Author

@bagder bagder commented Jun 15, 2022

Right, so I didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants