vtls: make curl_global_sslset thread-safe #9016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. and update some docs to explain curl_global_* is now thread-safe. Follow-up to 23af112 which made curl_global_init/cleanup thread-safe. Closes #xxxx
bagder
approved these changes
Jun 15, 2022
emanuele6
reviewed
Jun 15, 2022
| @@ -36,7 +36,11 @@ This function releases resources acquired by \fIcurl_global_init(3)\fP. | |||
| You should call \fIcurl_global_cleanup(3)\fP once for each call you make to | |||
| \fIcurl_global_init(3)\fP, after you are done using libcurl. | |||
|
|
|||
| \fBThis function is not thread safe.\fP You must not call it when any other | |||
| This function is thread-safe since libcurl 7.84.0 if | |||
| \fIcurl_version_info(3)\fP has CURL_VERSION_THREADSAFE feature bit set | |||
There was a problem hiding this comment.
Suggested change
| \fIcurl_version_info(3)\fP has CURL_VERSION_THREADSAFE feature bit set | |
| \fIcurl_version_info(3)\fP has the CURL_VERSION_THREADSAFE feature bit set |
| @@ -81,7 +81,11 @@ function again to try to select a different backend. | |||
| The SSL backend can be set only once. If it has already been set, a subsequent | |||
| attempt to change it will result in a \fBCURLSSLSET_TOO_LATE\fP. | |||
|
|
|||
| \fBThis function is not thread safe.\fP You must not call it when any other | |||
| This function is thread-safe since libcurl 7.84.0 if | |||
| \fIcurl_version_info(3)\fP has CURL_VERSION_THREADSAFE feature bit set | |||
There was a problem hiding this comment.
Suggested change
| \fIcurl_version_info(3)\fP has CURL_VERSION_THREADSAFE feature bit set | |
| \fIcurl_version_info(3)\fP has the CURL_VERSION_THREADSAFE feature bit set |
Comment on lines
+98
to
+99
| \fIcurl_version_info(3)\fP has CURL_VERSION_THREADSAFE feature bit set (most | ||
| platforms). |
There was a problem hiding this comment.
Suggested change
| \fIcurl_version_info(3)\fP has CURL_VERSION_THREADSAFE feature bit set (most | |
| platforms). | |
| \fIcurl_version_info(3)\fP has the CURL_VERSION_THREADSAFE feature bit set | |
| (most platforms). |
( I moved (most on the next line together with platforms) for consistency with docs/libcurl/curl_global_cleanup.3 )
| @@ -154,28 +154,31 @@ that library that describes the SSL protocol. | |||
| allocate resources (e.g. the memory for the GNU TLS tree mentioned above), so | |||
| the companion function \fIcurl_global_cleanup(3)\fP releases them. | |||
|
|
|||
| The basic rule for constructing a program that uses libcurl is this: Call | |||
| The global constant functions are thread-safe since libcurl 7.84.0 if | |||
| \fIcurl_version_info(3)\fP has CURL_VERSION_THREADSAFE feature bit set | |||
There was a problem hiding this comment.
Suggested change
| \fIcurl_version_info(3)\fP has CURL_VERSION_THREADSAFE feature bit set | |
| \fIcurl_version_info(3)\fP has the CURL_VERSION_THREADSAFE feature bit set |
Thanks, I landed it with that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. and update some docs to explain curl_global_* is now thread-safe.
Follow-up to 23af112 which made curl_global_init/cleanup thread-safe.
Closes #xxxx