Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/server/sockfilt.c: avoid race condition without a mutex #9023

Closed
wants to merge 1 commit into from

Conversation

mback2k
Copy link
Member

@mback2k mback2k commented Jun 16, 2022

Avoid loosing any triggered handles by first aborting and joining
the waiting threads before evaluating the individual signal state.

This removes the race condition and therefore need for a mutex.

@mback2k mback2k added tests Windows Windows-specific labels Jun 16, 2022
@mback2k mback2k self-assigned this Jun 16, 2022
@mback2k
Copy link
Member Author

mback2k commented Jun 19, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 19, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@mback2k
Copy link
Member Author

mback2k commented Jun 20, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jun 20, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Avoid loosing any triggered handles by first aborting and joining
the waiting threads before evaluating the individual signal state.

This removes the race condition and therefore need for a mutex.
@mback2k
Copy link
Member Author

mback2k commented Aug 23, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 23, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@mback2k mback2k marked this pull request as ready for review Aug 23, 2022
@mback2k mback2k closed this in 91948a9 Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Windows Windows-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant