Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: support ngtcp2 boringssl backend #9065

Closed
wants to merge 1 commit into from

Conversation

donny-dont
Copy link
Contributor

@donny-dont donny-dont commented Jun 28, 2022

Update the ngtcp2 find module to detect the boringssl backend. Determine if the underlying OpenSSL implementation is BoringSSL and if so use that as the ngtcp2 backend.

Update the ngtcp2 find module to detect the boringssl backend. Determine if the underlying OpenSSL implementation is BoringSSL and if so use that as the ngtcp2 backend.
@donny-dont
Copy link
Contributor Author

donny-dont commented Jun 28, 2022

Makes it so #8789 will build in CMake. I'm guessing maybe the autotools one already works with the ngtcp2 + BoringSSL backend. If not then something like this would also need to be done.

@donny-dont
Copy link
Contributor Author

donny-dont commented Jul 4, 2022

Hey @bagder anything in particular you want addressed here? I was able to build a version of curl with HTTP/3 support and run it in on the curl network backend in WebKit.

@bagder
Copy link
Member

bagder commented Jul 4, 2022

I was hoping someone who knows cmake would chime in...

@jzakrzewski
Copy link
Contributor

jzakrzewski commented Jul 5, 2022

I don't have time to build & test, but otherwise it looks clean to me.

@bagder
Copy link
Member

bagder commented Jul 5, 2022

Thanks @jzakrzewski that's good enough for me!

@bagder
Copy link
Member

bagder commented Jul 5, 2022

Thanks!

@bagder bagder closed this in 7f8b36b Jul 5, 2022
@donny-dont donny-dont deleted the boringssl-ngtcp2 branch Jul 5, 2022
@donny-dont
Copy link
Contributor Author

donny-dont commented Jul 5, 2022

Thanks @jzakrzewski and @bagder !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake HTTP/3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants