New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two memory leaks and one size check #913

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@mirekfranc
Contributor

mirekfranc commented Jul 13, 2016

My colleagues have run static analysis on curl code base.

Two memory leaks we found. One in function lib/file.c:fileconnect where memory pointed to by variable real_path is never returned when returning CURLE_URL_MALFORMAT from the function. The other is in function lib/pipeline.c:Curl_pipeline_set_server_blacklist where both new_list and server_name have potential of leaking memory in case CURLM_OUT_OF_MEMORY is returned from the function.

The second issue appears to be in function lib/sock_sspi.c:Curl_SOCKS5_gssapi_negotiate where service_name is allocated via malloc(strlen(service)) while I believe the resulting string should be null-terminated.

@mention-bot

This comment has been minimized.

mention-bot commented Jul 13, 2016

@mirekfranc, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bagder, @linusnielsen and @yangtse to be potential reviewers

@jay jay closed this in bf430ec Jul 14, 2016

@jay

This comment has been minimized.

Member

jay commented Jul 14, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment