Repository navigation
Two memory leaks and one size check - #913
Closed
mirekfranc wants to merge 3 commits into
Closed
mirekfranc wants to merge 3 commits into
mirekfranc wants to merge 3 commits into
Conversation
|
@mirekfranc, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bagder, @linusnielsen and @yangtse to be potential reviewers |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My colleagues have run static analysis on curl code base.
Two memory leaks we found. One in function lib/file.c:fileconnect where memory pointed to by variable real_path is never returned when returning CURLE_URL_MALFORMAT from the function. The other is in function lib/pipeline.c:Curl_pipeline_set_server_blacklist where both new_list and server_name have potential of leaking memory in case CURLM_OUT_OF_MEMORY is returned from the function.
The second issue appears to be in function lib/sock_sspi.c:Curl_SOCKS5_gssapi_negotiate where service_name is allocated via malloc(strlen(service)) while I believe the resulting string should be null-terminated.