Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.m32: add CURL_RC and CURL_STRIP variables [ci skip] #9132

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jul 10, 2022

They allow to override the hardcoded values for the windres and strip
tools, complementing the existing set of CURL_{CC,AR,RANLIB} variables.

CURL_RC comes handy when using LLVM tools with CROSSPREFIX=llvm- and
CURL_CC=clang set on current latest debian:unstable or earlier, where
llvm-windres is missing, and a CURL_RC=<triplet>-windres fixes it.
Hopefully this will be fixed in the llvm package. FWIW llvm-windres
does exist in Homebrew llvm, MSYS2 llvm and llvm-mingw.

@vszakats vszakats added build Windows labels Jul 10, 2022
They allow to override the hardcoded values for the `windres` and `strip`
tools, complementing the existing set of `CURL_{CC,AR,RANLIB}` variables.

`CURL_RC` comes handy when using LLVM tools with `CROSSPREFIX=llvm-` and
`CURL_CC=clang` set on current latest debian:unstable or earlier, where
`llvm-windres` is missing, and a `CURL_RC=<triplet>-windres` fixes it.
Hopefully this will be fixed in the llvm package. FWIW `llvm-windres`
does exist in Homebrew llvm, MSYS2 llvm and llvm-mingw.
bagder
bagder approved these changes Jul 10, 2022
vszakats added a commit to curl/curl-for-win that referenced this issue Jul 10, 2022
This requires patching curl's Makefile.m32 buils. PR opened: [1]

Fixes regression after 647eb3718782e92c6baa6cf3e9262ff315911b8c
and dcb1ea2.

[1] curl/curl#9132
@vszakats vszakats closed this in 1d5b7b7 Jul 10, 2022
@vszakats vszakats deleted the m32-rc-strip-conf branch Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants