Makefile.m32: stop trying to build libcares.a [ci skip] #9169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, `lib/Makefile.m32` had a rule to build `libcares.a` in `-cares`-enabled builds, via c-ares's own `Makefile.m32`. Committed in 2007 [1]. The commit message doesn't specifically address this particular change. No other curl dependency has such special treatment. It probably helped building a curl + c-ares combo in a single go, back when there were less optional curl dependencies? I can only guess. This feature creates problems when building c-ares first, using CMake and pointing `LIBCARES_PATH` to its install prefix, where `Makefile.m32` is missing in such case. A sub-build for c-ares is undesired also when c-ares had already been build via its own `Makefile.m32`. So, to avoid the sub-build, this patch deletes its Makefile rule. After this patch `libcares.a` needs to be manually built before using it in `Makefile.m32`. Aligning it with the rest of dependencies. [1] 46c92c0
bagder
approved these changes
Jul 17, 2022
|
I believe this might be tracing back from the oooold days when c-ares actually was a sub-tree in the curl source tree... |
|
Thanks for the historical insight, that explains it perfectly. I'm going to include it in the commit message. |
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jul 19, 2022
Experimental, not enabled by default and no promises to keep it around. ``` curl 7.84.0 (x86_64-w64-mingw32) libcurl/7.84.0 mbedTLS/3.2.1 (BoringSSL/7528f03c) (Schannel) zlib/1.2.12 brotli/1.0.9 zstd/1.5.2 c-ares/1.17.2 libidn2/2.3.3 libpsl/0.21.1 (+libidn2/2.3.3) libssh/0.9.6/openssl/zlib nghttp2/1.48.0 ngtcp2/0.6.0 nghttp3/0.5.0 libgsasl/1.10.0 Release-Date: 2022-06-27 Protocols: dict file ftp ftps gopher gophers http https imap imaps ldap ldaps mqtt pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp Features: alt-svc AsynchDNS brotli gsasl HSTS HTTP2 HTTP3 IDN IPv6 Kerberos Largefile libz MultiSSL NTLM PSL SPNEGO SSL SSPI threadsafe UnixSockets zstd ``` PR opened for issue when enabling c-ares with `Makefile.m32`: curl/curl#9169
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch,
lib/Makefile.m32had a rule to buildlibcares.ain-cares-enabled builds, via c-ares's ownMakefile.m32. Committed in2007 [1]. The commit message doesn't specifically address this particular
change. No other curl dependency has such special treatment. It probably
helped building a curl + c-ares combo in a single go, back when there
were less optional curl dependencies? I can only guess.
This feature creates problems when building c-ares first, using CMake
and pointing
LIBCARES_PATHto its install prefix, whereMakefile.m32is missing in such case. A sub-build for c-ares is undesired also when
c-ares had already been build via its own
Makefile.m32.So, to avoid the sub-build, this patch deletes its Makefile rule. After
this patch
libcares.aneeds to be manually built before using it inMakefile.m32. Aligning it with the rest of dependencies.[1] 46c92c0