New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Well, enable ZLIB_FOUND could be able specify by parent CMakeLists.tx… #917

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@lygstate
Contributor

lygstate commented Jul 14, 2016

…t directly without the need to find_package, that's would be useful when linkage to static zlib directly.

Well, enable ZLIB_FOUND could be able specify by parent CMakeLists.tx…
…t directly without the need to find_package, that's would be useful when linkage to static zlib directly.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 14, 2016

@lygstate, thanks for your PR! By analyzing the annotation information on this pull request, we identified @billhoffman, @Sukender and @Lekensteyn to be potential reviewers

mention-bot commented Jul 14, 2016

@lygstate, thanks for your PR! By analyzing the annotation information on this pull request, we identified @billhoffman, @Sukender and @Lekensteyn to be potential reviewers

@snikulov

This comment has been minimized.

Show comment
Hide comment
@snikulov

snikulov Jul 14, 2016

Member

@lygstate Could you please describe what problem you trying to solve?

Member

snikulov commented Jul 14, 2016

@lygstate Could you please describe what problem you trying to solve?

@lygstate

This comment has been minimized.

Show comment
Hide comment
@lygstate

lygstate Jul 14, 2016

Contributor

@snikulov I was trying to include libcurl in another CMake based system.
For example:

  add_subdirectory(zlib)



  set(BUILD_TESTING OFF CACHE BOOL "Disable curl tests")
  set(ZLIB_FOUND ON)
  set(ZLIB_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/zlib ${CMAKE_CURRENT_BINARY_DIR}/zlib)
  set(ZLIB_LIBRARIES zlibstatic)
  add_subdirectory(curl)
  target_include_directories(libcurl
    PUBLIC
    ${CMAKE_CURRENT_SOURCE_DIR}/curl/include
    ${CURL_BINARY_DIR}/include/curl
  )

So I could link zlib into libcurl as static library. And building zlib directly from souce without need the pre-build binaries

Contributor

lygstate commented Jul 14, 2016

@snikulov I was trying to include libcurl in another CMake based system.
For example:

  add_subdirectory(zlib)



  set(BUILD_TESTING OFF CACHE BOOL "Disable curl tests")
  set(ZLIB_FOUND ON)
  set(ZLIB_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/zlib ${CMAKE_CURRENT_BINARY_DIR}/zlib)
  set(ZLIB_LIBRARIES zlibstatic)
  add_subdirectory(curl)
  target_include_directories(libcurl
    PUBLIC
    ${CMAKE_CURRENT_SOURCE_DIR}/curl/include
    ${CURL_BINARY_DIR}/include/curl
  )

So I could link zlib into libcurl as static library. And building zlib directly from souce without need the pre-build binaries

@snikulov

This comment has been minimized.

Show comment
Hide comment
@snikulov

snikulov Jul 14, 2016

Member

@lygstate I don't think that adding more checks and conditions into curl's CMakeLists.txt for your personal reasons is a good idea, sorry. It is complicated enough already.
In addition, you trying to put more commits within single PR.
It is also bad idea, IMHO.

Member

snikulov commented Jul 14, 2016

@lygstate I don't think that adding more checks and conditions into curl's CMakeLists.txt for your personal reasons is a good idea, sorry. It is complicated enough already.
In addition, you trying to put more commits within single PR.
It is also bad idea, IMHO.

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Jul 15, 2016

Member

What is wrong with the call to check_library_exists_concat?

Member

jay commented Jul 15, 2016

What is wrong with the call to check_library_exists_concat?

@snikulov

This comment has been minimized.

Show comment
Hide comment
@snikulov

snikulov Jul 15, 2016

Member

@jay it's second unrelated to zlib change, which is not described in PR.

Member

snikulov commented Jul 15, 2016

@jay it's second unrelated to zlib change, which is not described in PR.

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Jul 16, 2016

Member

it's second unrelated to zlib change, which is not described in PR.

Possibly but I still want to know why he did it. As far as the zlib change goes I don't know enough about cmake build system to know whether this is a typical thing to want. It seems like he wants to override our settings with his own. Is that typical in cmake?

Member

jay commented Jul 16, 2016

it's second unrelated to zlib change, which is not described in PR.

Possibly but I still want to know why he did it. As far as the zlib change goes I don't know enough about cmake build system to know whether this is a typical thing to want. It seems like he wants to override our settings with his own. Is that typical in cmake?

@lygstate

This comment has been minimized.

Show comment
Hide comment
@lygstate

lygstate Jul 16, 2016

Contributor

@jay when I trying to compiling under win64 it's failed, that's why I am not calling to check_library_exists_concat directly

Contributor

lygstate commented Jul 16, 2016

@jay when I trying to compiling under win64 it's failed, that's why I am not calling to check_library_exists_concat directly

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Jul 18, 2016

Member

@jay when I trying to compiling under win64 it's failed, that's why I am not calling to check_library_exists_concat directly

How did it fail, can you give us any more information? I can't see why it would fail.

Member

jay commented Jul 18, 2016

@jay when I trying to compiling under win64 it's failed, that's why I am not calling to check_library_exists_concat directly

How did it fail, can you give us any more information? I can't see why it would fail.

@bagder bagder added the cmake label Jul 21, 2016

jay added a commit that referenced this pull request Jul 28, 2016

cmake: Fix for schannel support
The check_library_exists_concat do not check crypt32 library properly.
So include it directly.

Bug: #917
Reported-by: Yonggang Luo

Bug: #935
Reported-by: Alain Danteny
@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Jul 28, 2016

Member

@lygstate your fix for the crypt32 issue has landed in 2bbed9c, thanks.

Member

jay commented Jul 28, 2016

@lygstate your fix for the crypt32 issue has landed in 2bbed9c, thanks.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Oct 16, 2016

Member

No response for months. Dead.

Member

bagder commented Oct 16, 2016

No response for months. Dead.

@bagder bagder closed this Oct 16, 2016

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.