Well, enable ZLIB_FOUND could be able specify by parent CMakeLists.tx… #917
Conversation
…t directly without the need to find_package, that's would be useful when linkage to static zlib directly.
@lygstate, thanks for your PR! By analyzing the annotation information on this pull request, we identified @billhoffman, @Sukender and @Lekensteyn to be potential reviewers |
So include it directly.
@lygstate Could you please describe what problem you trying to solve? |
@snikulov I was trying to include libcurl in another CMake based system.
So I could link zlib into libcurl as static library. And building zlib directly from souce without need the pre-build binaries |
@lygstate I don't think that adding more checks and conditions into curl's CMakeLists.txt for your personal reasons is a good idea, sorry. It is complicated enough already. |
What is wrong with the call to |
@jay it's second unrelated to zlib change, which is not described in PR. |
Possibly but I still want to know why he did it. As far as the zlib change goes I don't know enough about cmake build system to know whether this is a typical thing to want. It seems like he wants to override our settings with his own. Is that typical in cmake? |
@jay when I trying to compiling under win64 it's failed, that's why I am not calling to check_library_exists_concat directly |
How did it fail, can you give us any more information? I can't see why it would fail. |
No response for months. Dead. |
…t directly without the need to find_package, that's would be useful when linkage to static zlib directly.