h2h3: Fix bug overriding the 'TE: Trailers' header #9170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A 'TE: Trailers' header is explicitly replaced by 'te: trailers' (lowercase) in Curl_pseudo_headers() when building the list of HTTP/2 or HTTP/3 headers. However, this is then replaced again by the original value due to a bug, resulting in the uppercased version being sent. Some HTTP/2 servers reject the whole HTTP/2 stream when this is the case.
bagder
approved these changes
Jul 18, 2022
|
Thanks! |
lwthiker
added a commit
to lwthiker/curl
that referenced
this pull request
Jul 22, 2022
A 'TE: Trailers' header is explicitly replaced by 'te: trailers' (lowercase) in Curl_pseudo_headers() when building the list of HTTP/2 or HTTP/3 headers. However, this is then replaced again by the original value due to a bug, resulting in the uppercased version being sent. Some HTTP/2 servers reject the whole HTTP/2 stream when this is the case. Closes curl#9170
lwthiker
added a commit
to lwthiker/curl
that referenced
this pull request
Jul 22, 2022
A 'TE: Trailers' header is explicitly replaced by 'te: trailers' (lowercase) in Curl_pseudo_headers() when building the list of HTTP/2 or HTTP/3 headers. However, this is then replaced again by the original value due to a bug, resulting in the uppercased version being sent. Some HTTP/2 servers reject the whole HTTP/2 stream when this is the case. Closes curl#9170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 'TE: Trailers' header is explicitly replaced by 'te: trailers'
(lowercase) in Curl_pseudo_headers() when building the list of HTTP/2
or HTTP/3 headers. However, this is then replaced again by the original
value due to a bug, resulting in the uppercased version being sent. Some
HTTP/2 servers reject the whole HTTP/2 stream when this is the case.
Fixes #9171