-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Intel CI #9179
Add Intel CI #9179
Conversation
Your edits made the lines too long:
|
Oops. I can fix that if you like if you can tell me what's a good comment you'd like. (I guess I'm an "unlimited line length" sort of programmer. 😄 ) Or maybe there's a way to get you write access to my branch on my fork? Either is fine! |
We don't have any particular rules for how comments should look like, as long as they don't make the lines longer than 79 columns. |
b11cb30
to
c49a03b
Compare
I also took the liberty to force-push after I rebased this branch on top of the recent ftp fix for icc. |
Gosh, it really does not like getinfo.c...
|
The intel compiler warning 2259 ( |
@bagder Note that the way you are disabling the warnings with
Looking at their docs, it seems like the translation (on Linux/macOS) is:
|
@mathomp4 thanks, I failed to find which updated options to use myself so your help is appreciated. I'll switch to using them too as part of the work in this PR. |
-wd and -we are deprecated and are now -diag-disable and -diag-error Disable warning 1024 and 2259
To fix the icc warning enumerated type mixed with another type
As it caused icc to complain: "pointer cast involving 64-bit pointed-to type"
As virtually no called checked the return code, and those that did wrongly treated it as a CURLcode. Detected by the icc compiler warning: enumerated type mixed with another type
It does not return a CURLcode. Detected by the icc compiler warning "enumerated type mixed with another type"
To fix icc compiler warning integer conversion resulted in a change of sign
To match set.method used for the same purpose.
error curl#188: enumerated type mixed with another type
To avoid "enumerated type mixed with another type"
Follow-up to 1c58e7ae99ce2030213f28b
"enumerated type mixed with another type"
The specific reason was not used.
To please icc
efba3ae
to
d7e9e92
Compare
ok, I did the wrong |
-wd and -we are deprecated and are now -diag-disable and -diag-error Disable warning 1024 and 2259 Closes #9179
To fix the icc warning enumerated type mixed with another type Closes #9179
As it caused icc to complain: "pointer cast involving 64-bit pointed-to type" Closes #9179
As virtually no called checked the return code, and those that did wrongly treated it as a CURLcode. Detected by the icc compiler warning: enumerated type mixed with another type Closes #9179
It does not return a CURLcode. Detected by the icc compiler warning "enumerated type mixed with another type" Closes #9179
To fix icc compiler warning integer conversion resulted in a change of sign Closes #9179
To match set.method used for the same purpose. Closes #9179
To avoid "enumerated type mixed with another type" Closes #9179
Follow-up to 1c58e7ae99ce2030213f28b Closes #9179
"enumerated type mixed with another type" Closes #9179
The specific reason was not used. Closes #9179
Thanks @mathomp4 ! |
This PR adds Intel oneAPI to the CI for curl. At the moment it doesn't work due to various Intel C issues with curl, but this PR might help figure those out?