Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyper: enable obs-folded multiline headers #9216

Closed
wants to merge 1 commit into from

Conversation

seanmonstar
Copy link
Contributor

@seanmonstar seanmonstar commented Jul 27, 2022

This enables the option in hyper to allow obs-folded multiline headers, which makes test 1940 pass.


I was hopeful this would fix test 1274, but it seems that test is expecting to receive the bytes before the value is unfolded, and hyper unfolds as part of the parsing step. The header value is still received, just without the newlines. So a curl user depending on a folded header could still work, if they don't blindly unfold.

We can either edit that test directly to allow the expected output to be unfolded if hyper is enabled, or disable the test directly.

bagder
bagder approved these changes Jul 27, 2022
@bagder
Copy link
Member

bagder commented Jul 27, 2022

Yeah, we probably need to edit the 1274 test a little to make it run with hyper.

@bagder
Copy link
Member

bagder commented Jul 27, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants