Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: quiche build failure #9223

Closed
wants to merge 1 commit into from
Closed

Conversation

orisano
Copy link
Contributor

@orisano orisano commented Jul 29, 2022

quiche support build was failing since cloudflare/quiche@3e719a3.
I fixed them.

@bagder bagder added build HTTP/3 h3 or quic related labels Jul 31, 2022
@bagder bagder requested a review from ghedo Jul 31, 2022
ghedo
ghedo approved these changes Aug 1, 2022
Copy link
Member

@ghedo ghedo left a comment

LGTM, thanks!

@bagder
Copy link
Member

bagder commented Aug 2, 2022

thanks!

@bagder bagder closed this in 2086b69 Aug 2, 2022
@orisano orisano deleted the fix-quiche-build branch Aug 2, 2022
@Zackptg5
Copy link

Zackptg5 commented Sep 5, 2022

Note that this quiche change was made after current 0.14 release so if building curl with quiche release rather than master branch, this commit will need reverted until the next quiche release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build HTTP/3 h3 or quic related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants