Skip to content

fix: quiche build failure#9223

Closed
orisano wants to merge 1 commit intocurl:masterfrom
orisano:fix-quiche-build
Closed

fix: quiche build failure#9223
orisano wants to merge 1 commit intocurl:masterfrom
orisano:fix-quiche-build

Conversation

@orisano
Copy link
Copy Markdown
Contributor

@orisano orisano commented Jul 29, 2022

quiche support build was failing since cloudflare/quiche@3e719a3.
I fixed them.

@orisano orisano force-pushed the fix-quiche-build branch from e24f90b to bff571d Compare July 29, 2022 09:01
@orisano orisano force-pushed the fix-quiche-build branch from bff571d to a9f39d9 Compare July 29, 2022 09:11
@bagder bagder added build HTTP/3 h3 or quic related labels Jul 31, 2022
@bagder bagder requested a review from ghedo July 31, 2022 16:48
Copy link
Copy Markdown
Contributor

@ghedo ghedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bagder
Copy link
Copy Markdown
Member

bagder commented Aug 2, 2022

thanks!

@bagder bagder closed this in 2086b69 Aug 2, 2022
@orisano orisano deleted the fix-quiche-build branch August 2, 2022 17:41
@Zackptg5
Copy link
Copy Markdown

Zackptg5 commented Sep 5, 2022

Note that this quiche change was made after current 0.14 release so if building curl with quiche release rather than master branch, this commit will need reverted until the next quiche release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

4 participants