curl-config: quote directories with potential space

[orgads]

On Windows (at least with CMake), the default prefix is
C:/Program Files (x86)/CURL.

[bagder]

I don't think changing the format of that data is going to make existing users of this happy. I would prefer to have users opt-in to have spaces treated correctly. Maybe with a new switch. Maybe we should then do an overhaul of all outputs in there and see if they could be improved for this aspect?

[orgads]

I don't think changing the format of that data is going to make existing users of this happy. I would prefer to have users opt-in to have spaces treated correctly. Maybe with a new switch. Maybe we should then do an overhaul of all outputs in there and see if they could be improved for this aspect?

The current script has invalid syntax when there are spaces in prefix or libdir. I only fixed those that prevent it from running.

Every time I run runtests.pl, I get a warning:

../curl-config: line 26: syntax error near unexpected token `('
../curl-config: line 26: `prefix=C:/Program Files (x86)/CURL'

And a similar one for line 177.

[bagder]

I only fixed those that prevent it from running.

Right, that was the line 26 edit. The line 177 one is different. It adds double quotes to the output and assumes that the user of the option will handle them properly. I presume it breaks if the path itself contains double quotes.

[orgads]

I added the internal quotes following your previous review. The output looks reasonable to me.

Do you have a better alternative? Do you prefer changing the default prefix to something without spaces maybe?

[bagder]

I added the internal quotes following your previous review. The output looks reasonable to me.

Yes, it is probably a reasonable format if we would create it as a new format today. But we aren't. We change an existing output that presumably existing tools/scripts already parse and use. Keeping those existing users is an important property. So I would like the change to be done with minimum risk of breakage.

[orgads]

Ok, reverted to the first revision (no extra quotes in the output).

[bagder]

Thanks!