Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file: add handling of native AmigaOS paths #9259

Closed
wants to merge 2 commits into from

Conversation

Futaura
Copy link
Contributor

@Futaura Futaura commented Aug 6, 2022

On AmigaOS 4.x, handle native absolute paths, whilst blocking relative
paths. Also allow unix style paths if feature enabled at link time.

Inspiration-from: Michael Trebilcock

On AmigaOS 4.x, handle native absolute paths, whilst blocking relative
paths. Also allow unix style paths if feature enabled at link time.

Inspiration-from: Michael Trebilcock
lib/file.c Outdated Show resolved Hide resolved
* A leading slash in an AmigaDOS path denotes the parent
* directory, and hence we block this as it is relative.
* Absolute paths start with 'volumename:', so we check for
* this first. Failing that, we treat the path as a real unix
Copy link
Member

@bagder bagder Aug 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the volume name be any length? Or maybe it doesn't matter as the open will just fail anyway if tried with a too long name?

Copy link
Contributor Author

@Futaura Futaura Aug 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the volume name be any length? Or maybe it doesn't matter as the open will just fail anyway if tried with a too long name?

I'm not sure on the length limit (probably 107 characters, at a guess), but it may also differ depending which filesystem is used. Normally, volume names are not that long though, but equally always longer than the drive letter than Windows uses. It shouldn't be a concern and, yes, the file open will fail anyway if the volume name doesn't actually exist.

lib/file.c Outdated Show resolved Hide resolved
bagder
bagder approved these changes Aug 8, 2022
@bagder bagder closed this in 23c708c Aug 8, 2022
@bagder
Copy link
Member

bagder commented Aug 8, 2022

thanks!

@Futaura Futaura deleted the file_amiga_path_handling branch Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants