ldap: adapt to conn->port now being an 'int'#9281
Closed
Conversation
Remove typecasts. Fix printf() formats. Follow-up from 764c6bd. Pointed out by Coverity CID 1507858.
cvengler
reviewed
Aug 8, 2022
Contributor
cvengler
left a comment
cvengler
left a comment
There was a problem hiding this comment.
Isn't %d more natural for an int?
Member
Author
|
since the output is always unsigned I figured %u makes it more obvious |
Contributor
But, at that point, wouldn't it mane more sense to change conn->port to an unsigned int anyway? Although not the scope of this PR, obviously. |
Member
Author
|
I don't think it does, as that will just cause some more typecasts or require conversions elsewhere. The printf format string is for how it outputs the number, %d and %u both work on the same int input. It's not an error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove typecasts. Fix printf() formats.
Follow-up from 764c6bd.
Pointed out by Coverity CID 1507858.