Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory debug tracking annotates whether the returns pointer does not … #9306

Closed
wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Aug 13, 2022

alias,

hints where the size required is, for Windows to be better debuggued
via Visual Studio.

lib/memdebug.h Outdated Show resolved Hide resolved
bagder
bagder approved these changes Aug 13, 2022
Copy link
Member

@bagder bagder left a comment

Ah, this seems clever!

@bagder
Copy link
Member

bagder commented Aug 13, 2022

Visual Studio 2015 however, is not happy:

2>wolfssl.c
2>C:\projects\curl\lib\memdebug.h(52) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(54) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(59) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(98) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(100) : error C2485: 'allocator' : unrecognized extended attribute
2>vtls.c
2>sectransp.c
2>C:\projects\curl\lib\memdebug.h(52) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(54) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(59) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(98) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(100) : error C2485: 'allocator' : unrecognized extended attribute
2>schannel_verify.c
2>schannel.c
2>C:\projects\curl\lib\memdebug.h(52) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(54) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(59) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(98) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(100) : error C2485: 'allocator' : unrecognized extended attribute
2>rustls.c
2>C:\projects\curl\lib\memdebug.h(52) : error C2485: 'allocator' : unrecognized extended attribute
2>C:\projects\curl\lib\memdebug.h(54) : error C2485: 'allocator' : unrecognized extended attribute

@devnexen
Copy link
Contributor Author

devnexen commented Aug 13, 2022

ah ok 2015 ... ok I m going to remove this specific attr

@MarcelRaad
Copy link
Member

MarcelRaad commented Aug 13, 2022

The attributes are required on the implementation too to fix the MSVC build (visible on AppVeyor). Looks good to me apart from that!

…`alias`,

 hints where the size required is, for Windows to be better debuggued
via Visual Studio.
Copy link
Member

@MarcelRaad MarcelRaad left a comment

Thanks! The remaining CI failures look unrelated to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants