Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.m32: allow -nghttp3/-ngtcp2 without -ssl [ci skip] #9314

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Aug 15, 2022

Before this patch -nghttp3/-ngtcp2 had an effect only when -ssl was
also enabled. -ssl meaning OpenSSL (and its forks). After
8a13be2 nghttp3/ngtcp2 can also be used
together with wolfSSL. This patch adds the ability to enable
-nghttp3/-ngtcp2 independently from -ssl (OpenSSL), allowing to use
it with wolfSSL or other, future TLS backends.

Before this patch, it was fine to enable -nghttp3/-ngtcp2
unconditionally. After this patch, this is no longer the case, and now
it's the user's responsibility to enable -nghttp3/-ngtcp2 only
together with a compatible TLS backend.

When using a TLS backend other than OpenSSL, the TLS-specific ngtcp2
library must be configured manually, e.g.:
export CURL_LDFLAG_EXTRAS=-lngtcp2_crypto_wolfssl

Before this patch `-nghttp3`/`-ngtcp2` had an effect only when `-ssl` was
also enabled. `-ssl` meaning OpenSSL (and its forks). After
8a13be2 nghttp3/ngtcp2 can also be used
together with wolfSSL. This patch adds the ability to enable
`-nghttp3`/`-ngtcp2` independently from `-ssl` (OpenSSL), allowing to use
it with wolfSSL or other, future TLS backends.

Before this patch, it was fine to enable `-nghttp3`/`-ngtcp2`
unconditionally. After this patch, this is no longer the case, and now
it's the user's responsibility to enable `-nghttp3`/`-ngtcp2` only
together with a compatible TLS backend.

When using a TLS backend other than OpenSSL, the TLS-specific ngtcp2
library must be configured manually, e.g.:
  `export CURL_LDFLAG_EXTRAS=-lngtcp2_crypto_wolfssl`
@vszakats vszakats changed the title Makefile.m32: allow -nghttp3/-ngtcp2 options without -ssl [ci skip] Makefile.m32: allow -nghttp3/-ngtcp2 without -ssl [ci skip] Aug 15, 2022
@vszakats vszakats closed this in 5fd7cd7 Aug 15, 2022
@vszakats vszakats deleted the m32-h3-fixup branch Aug 15, 2022
vszakats added a commit to curl/curl-for-win that referenced this issue Aug 15, 2022
…skip]

Apply upstream patch:
curl/curl@5fd7cd7
curl/curl#9314

This allows to enable nghttp3+ngtcp2 for non-OpenSSL TLS backends.

In preparation for wolfSSL HTTP/3 support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant