multi_wait: fix skipping to populate revents for extra_fds #9361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #9364 to be merged to re-run tests. |
MarcelRaad
approved these changes
Aug 25, 2022
jay
approved these changes
Aug 25, 2022
On Windows revents was not populated for extra_fds if multi_wait had to wait due to the Curl_poll pre-check not signalling any readyness. This commit fixes that. Reviewed-by: Marcel Raad Reviewed-by: Jay Satiro Closes curl#9361
mback2k
force-pushed
the
fix-multi_wait-revents
branch
from
2c74f37
to
cfd2449
Compare
|
Just checked: failed CIs are irrelevant for this change. So going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Splitting from #9203 to merge before the pending release:
On Windows revents was not populated for extra_fds if
multi_wait had to wait due to the Curl_poll pre-check
not signalling any readyness. This commit fixes that.