Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURLOPT_WILDCARDMATCH.3: Fix backslash escaping under single quotes #9418

Closed

Conversation

samueloph
Copy link
Contributor

@samueloph samueloph commented Sep 2, 2022

Lintian (on Debian) has been complaining about this for a while but
I didn't bother initially as the groff parser that we use is not
affected by this.

But I have now noticed that the online manpage is affected by it:
https://curl.se/libcurl/c/CURLOPT_WILDCARDMATCH.html

(I'm using double quotes for quoting-only down below)

The section that should be parsed as "'\'" ends up being parsed as
"'´".

This is due to roffit not parsing "'\\'" correctly, which is fine
as the "correct" way of writing "'\'" is "'\e'" instead.

Note that this fix is not enough to fix the online manpage at
curl's website, as roffit seems to parse it wrongly either way.

My intent is to at least fix the manpage so that roffit can
be changed to parse "'\e'" correctly (although I suggest making
roffit parse both ways correctly, since that's what groff does).

More details at:
https://bugs.debian.org/966803
https://salsa.debian.org/lintian/lintian/-/blob/930b18e4b28b7540253f458ef42a884cca7965c3/tags/a/acute-accent-in-manual-page.tag

 Lintian (on Debian) has been complaining about this for a while but
 I didn't bother initially as the groff parser that we use is not
 affected by this.

 But I have now noticed that the online manpage is affected by it:
 https://curl.se/libcurl/c/CURLOPT_WILDCARDMATCH.html

 (I'm using double quotes for quoting-only down below)

 The section that should be parsed as "'\'" ends up being parsed as
 "'´".

 This is due to roffit not parsing "'\\'" correctly, which is fine
 as the "correct" way of writing "'\'" is "'\e'" instead.

 Note that this fix is not enough to fix the online manpage at
 curl's website, as roffit seems to parse it wrongly either way.

 My intent is to at least fix the manpage so that roffit can
 be changed to parse "'\e'" correctly (although I suggest making
 roffit parse both ways correctly, since that's what groff does).

 More details at:
 https://bugs.debian.org/966803
 https://salsa.debian.org/lintian/lintian/-/blob/930b18e4b28b7540253f458ef42a884cca7965c3/tags/a/acute-accent-in-manual-page.tag
bagder added a commit to bagder/roffit that referenced this issue Sep 2, 2022
... just to make them less likely to cause problems down the road.

Bug: curl/curl#9418
Reported-by: Samuel Henrique
bagder added a commit to bagder/roffit that referenced this issue Sep 2, 2022
Bug: curl/curl#9418
Reported-by: Samuel Henrique
bagder
bagder approved these changes Sep 2, 2022
Copy link
Member

@bagder bagder left a comment

I have made bagder/roffit#26 in the mean time

@bagder
Copy link
Member

bagder commented Sep 2, 2022

Thanks!

@bagder bagder closed this in 5c095a4 Sep 2, 2022
bagder added a commit to bagder/roffit that referenced this issue Sep 2, 2022
Bug: curl/curl#9418
Reported-by: Samuel Henrique

Closes #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants