Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: ISSPACE() => ISBLANK() #9432

Closed
wants to merge 2 commits into from
Closed

misc: ISSPACE() => ISBLANK() #9432

wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 5, 2022

Instances of ISSPACE() use that should rather use ISBLANK(). I think somewhat carelessly used because it sounds as if it checks for space or whitespace, but also includes %0a to %0d.

For parsing purposes, we should only accept what we must and not be overly liberal. It leads to surprises and surprises lead to bad things.

Instances of ISSPACE() use that should rather use ISBLANK(). I think
somewhat carelessly used because it sounds as if it checks for space or
whitespace, but also includes %0a to %0d.

For parsing purposes, we should only accept what we must and not be
overly liberal. It leads to surprises and surprises lead to bad things.
@bagder bagder added the tidy-up label Sep 5, 2022
@bagder bagder closed this in 6f9fb7e Sep 6, 2022
@bagder bagder deleted the bagder/isspace-isblank branch Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant