http2: make nghttp2 less picky about field whitespace #9448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In nghttp2 1.49.0 it return error on leading and trailing whitespace in header fields according to language in the recently shipped RFC 9113. nghttp2 1.50.0 introduces an option to switch off this strict check and this change enables this by default which should make curl behave more similar to how it did with nghttp2 1.48.0 and earlier. We might want to consider making this an option in the future.
jay
approved these changes
Sep 7, 2022
|
I verified that this PR built fine with current nghttp2 1.50.0-DEV version in a local build, and that it didn't cause any obvious issues, but I did not try it against any white-space-field sites. |
This was referenced Sep 12, 2022
robot-piglet
pushed a commit
to ydb-platform/ydb
that referenced
this pull request
Sep 15, 2022
This is backport of: * curl [PR #9448](curl/curl#9448) * nghttp2 [PR #1792](nghttp2/nghttp2#1792)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In nghttp2 1.49.0 it returns error on leading and trailing whitespace in header fields according to language in the recently shipped RFC 9113.
nghttp2 1.50.0 introduces an option to switch off this strict check and this change enables this by default which should make curl behave more similar to how it did with nghttp2 1.48.0 and earlier.
We might want to consider making this an option in the future.