Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: make nghttp2 less picky about field whitespace #9448

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 7, 2022

In nghttp2 1.49.0 it returns error on leading and trailing whitespace in header fields according to language in the recently shipped RFC 9113.

nghttp2 1.50.0 introduces an option to switch off this strict check and this change enables this by default which should make curl behave more similar to how it did with nghttp2 1.48.0 and earlier.

We might want to consider making this an option in the future.

In nghttp2 1.49.0 it return error on leading and trailing whitespace in
header fields according to language in the recently shipped RFC 9113.

nghttp2 1.50.0 introduces an option to switch off this strict check and
this change enables this by default which should make curl behave more
similar to how it did with nghttp2 1.48.0 and earlier.

We might want to consider making this an option in the future.
@bagder bagder added the HTTP/2 label Sep 7, 2022
jay
jay approved these changes Sep 7, 2022
@bagder
Copy link
Member Author

bagder commented Sep 7, 2022

I verified that this PR built fine with current nghttp2 1.50.0-DEV version in a local build, and that it didn't cause any obvious issues, but I did not try it against any white-space-field sites.

@bagder bagder closed this in eafc2b1 Sep 8, 2022
@bagder bagder deleted the bagder/http2-less-picky-ws-fields branch Sep 8, 2022
robot-piglet pushed a commit to ydb-platform/ydb that referenced this issue Sep 15, 2022
This is backport of:

* curl [PR #9448](curl/curl#9448)
* nghttp2 [PR #1792](nghttp2/nghttp2#1792)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants