Avoid setting redundant CFLAGS to compile commands #949

Merged
merged 1 commit into from Aug 8, 2016

Projects

None yet

3 participants

@webmaster128
Contributor

In the 5 locations where $(CURL_CC) is used, $(CURL_CFLAGS) is always appended, so before this, all arguments in CURL_CFLAGS have been added twice.

Confirm the following snipped from the build log (indent added):

Copying libs...
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Zm200 /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\tool_hugehelp.obj"↩
        ..\src\tool_hugehelp.c
tool_hugehelp.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\nonblock.obj"↩
        ../lib/nonblock.c
nonblock.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\rawstr.obj"↩
        ../lib/rawstr.c
rawstr.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\strtoofft.obj"↩
        ../lib/strtoofft.c
strtoofft.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\warnless.obj"↩
        ../lib/warnless.c
warnless.c
@webmaster128 webmaster128 Avoid setting redundant CFLAGS to compile commands
$(CURL_CC) is always used with $(CURL_CFLAGS) appended, so before this,
all arguments in CURL_CFLAGS have been added twice.
9747fd1
@mention-bot

@webmaster128, thanks for your PR! By analyzing the annotation information on this pull request, we identified @yangtse, @mback2k and @BurningEnlightenment to be potential reviewers

@bagder bagder merged commit 26424ba into curl:master Aug 8, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@bagder
Member
bagder commented Aug 8, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment