Skip to content

Avoid setting redundant CFLAGS to compile commands#949

Merged
bagder merged 1 commit intocurl:masterfrom
webmaster128:redundant-cflags
Aug 8, 2016
Merged

Avoid setting redundant CFLAGS to compile commands#949
bagder merged 1 commit intocurl:masterfrom
webmaster128:redundant-cflags

Conversation

@webmaster128
Copy link
Copy Markdown
Contributor

In the 5 locations where $(CURL_CC) is used, $(CURL_CFLAGS) is always appended, so before this, all arguments in CURL_CFLAGS have been added twice.

Confirm the following snipped from the build log (indent added):

Copying libs...
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Zm200 /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\tool_hugehelp.obj"↩
        ..\src\tool_hugehelp.c
tool_hugehelp.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\nonblock.obj"↩
        ../lib/nonblock.c
nonblock.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\rawstr.obj"↩
        ../lib/rawstr.c
rawstr.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\strtoofft.obj"↩
        ../lib/strtoofft.c
strtoofft.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\warnless.obj"↩
        ../lib/warnless.c
warnless.c

$(CURL_CC) is always used with $(CURL_CFLAGS) appended, so before this,
all arguments in CURL_CFLAGS have been added twice.
@mention-bot
Copy link
Copy Markdown

@webmaster128, thanks for your PR! By analyzing the annotation information on this pull request, we identified @yangtse, @mback2k and @BurningEnlightenment to be potential reviewers

@bagder bagder merged commit 26424ba into curl:master Aug 8, 2016
@bagder
Copy link
Copy Markdown
Member

bagder commented Aug 8, 2016

thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants