New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid setting redundant CFLAGS to compile commands #949

Merged
merged 1 commit into from Aug 8, 2016

Conversation

Projects
None yet
3 participants
@webmaster128
Contributor

webmaster128 commented Aug 8, 2016

In the 5 locations where $(CURL_CC) is used, $(CURL_CFLAGS) is always appended, so before this, all arguments in CURL_CFLAGS have been added twice.

Confirm the following snipped from the build log (indent added):

Copying libs...
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Zm200 /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\tool_hugehelp.obj"↩
        ..\src\tool_hugehelp.c
tool_hugehelp.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\nonblock.obj"↩
        ../lib/nonblock.c
nonblock.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\rawstr.obj"↩
        ../lib/rawstr.c
rawstr.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\strtoofft.obj"↩
        ../lib/strtoofft.c
strtoofft.c
    cl.exe /O2 /DNDEBUG /MD /DCURL_STATICLIB↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /I../lib /I../include /nologo /W3 /EHsc /DWIN32 /FD /c↩
        /Fo"..\builds\libcurl-vc14-x86-release-static-ipv6-sspi-winssl-obj-curl\warnless.obj"↩
        ../lib/warnless.c
warnless.c
Avoid setting redundant CFLAGS to compile commands
$(CURL_CC) is always used with $(CURL_CFLAGS) appended, so before this,
all arguments in CURL_CFLAGS have been added twice.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 8, 2016

@webmaster128, thanks for your PR! By analyzing the annotation information on this pull request, we identified @yangtse, @mback2k and @BurningEnlightenment to be potential reviewers

mention-bot commented Aug 8, 2016

@webmaster128, thanks for your PR! By analyzing the annotation information on this pull request, we identified @yangtse, @mback2k and @BurningEnlightenment to be potential reviewers

@bagder bagder merged commit 26424ba into curl:master Aug 8, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 8, 2016

Member

thanks!

Member

bagder commented Aug 8, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment