scripts: use grep -E instead of egrep
#9491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanuele6
reviewed
Sep 12, 2022
MacOSX-Framework
Outdated
Comment on lines
90
to
91
| OLD_SDK64=`ls $SDK_PATH|egrep -v "10.[0-4]"|head -1` | ||
| NEW_SDK64=`ls -r $SDK_PATH|egrep -v "10.[0-4][^0-9]" | head -1` | ||
| OLD_SDK64=`ls $SDK_PATH|grep -Ev "10.[0-4]"|head -1` | ||
| NEW_SDK64=`ls -r $SDK_PATH|grep -Ev "10.[0-4][^0-9]" | head -1` |
There was a problem hiding this comment.
you don't need to use -E here
There was a problem hiding this comment.
I didn't want to change the script more than I had to.
There was a problem hiding this comment.
Strictly speaking, . should be escaped here as well. This, and dropping -E are fine within this PR IMO.
We have more egreps in this file:
.github/workflows/hacktoberfest-accepted.yml: egrep -i "^Close[sd]? " | sort | uniq | tee log
.github/workflows/hacktoberfest-accepted.yml: egrep -o "#([0-9]+)" log | cut -d# -f2 | sort | uniq | xargs -t -n1 -I{} \
.github/workflows/hacktoberfest-accepted.yml: egrep -o '^([0-9]+):[0-9]{4}-(09-30T|10-|11-01T)' | cut -d: -f1 | sort | uniq | xargs -t -n1 -I {} \
.github/workflows/hacktoberfest-accepted.yml: egrep -o "github.com/(.+)/(.+)/pull/([0-9]+)" log | sort | uniq | xargs -t -n1 -I{} \
.github/workflows/hacktoberfest-accepted.yml: egrep -o '^([0-9]+):[0-9]{4}-(09-30T|10-|11-01T)' | cut -d: -f1 | sort | uniq | xargs -t -n1 -I {} \
There was a problem hiding this comment.
Addressed your comments in the fixed up commit.
|
Fixed up the commit by removing Also replaced |
vszakats
approved these changes
Sep 13, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latest GNU grep emits a deprecation message when
egrepis invoked. All platforms that can be expected to run the three changed scripts already havegrep -Eas a replacement.