Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: add a CI job that runs proselint on all markdown files #9520

Merged
merged 2 commits into from Sep 19, 2022

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 16, 2022

No description provided.

@bagder bagder added the CI Continuous Integration label Sep 16, 2022
@bagder bagder requested review from cmeister2 and mback2k as code owners Sep 16, 2022
Copy link
Contributor

@cmeister2 cmeister2 left a comment

Think the proselintrc file handling needs a rethink.

.github/workflows/proselint.yml Outdated Show resolved Hide resolved
.github/workflows/proselint.yml Outdated Show resolved Hide resolved
@bagder
Copy link
Member Author

bagder commented Sep 16, 2022

ok, seems to work now, rebased and squashed into something readable

@bagder bagder requested a review from cmeister2 Sep 17, 2022
Copy link
Contributor

@cmeister2 cmeister2 left a comment

I have a minor quibble with how the proselint json files are mastered, but this is only a recommendation. (I feel like introducing grep and sed into the process is a mistake)

.github/workflows/proselint.yml Outdated Show resolved Hide resolved
.github/workflows/proselint.yml Outdated Show resolved Hide resolved
@bagder
Copy link
Member Author

bagder commented Sep 19, 2022

Thanks @mback2k, I've squashed this all into two commits now.

@bagder bagder closed this in 6e0dbe8 Sep 19, 2022
@bagder bagder merged commit fda897f into master Sep 19, 2022
62 of 86 checks passed
@bagder bagder deleted the bagder/proselint branch Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants