Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test1119: scan all public headers #9544

Closed
wants to merge 7 commits into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Sep 20, 2022

Previously this test only scanned a subset of the headers, which made us accidentally miss symbols that were provided in the others. Now, the script iterates over all headers present in include/curl.

@bagder
Copy link
Member Author

bagder commented Sep 21, 2022

This updated scan also correctly finds the #9552 issue, a wrongly spelled CURLH_* define.

@bagder
Copy link
Member Author

bagder commented Sep 21, 2022

#9523 fixes that issue, and I will rerun this build once that has landed to confirm.

bagder added 6 commits Sep 21, 2022
Previously this test only scanned a subset of the headers, which made us
accidentally miss symbols that were provided in the others. Now, the script
iterates over all headers present in include/curl.
This script now also finds all .3 man pages in docs/include and
docs/include/opts, extracts all uses of CURL* symbols and verifies that all
symbols mentioned in docs are defined in public headers.

A "global symbol" is one of those matching a known prefix and the script makes
an attempt to check all/most of them. Just using *all* symbols that match
CURL* proved matching a little too many other references as well and turned
difficult turning into something useful.
The same error and comment were also used and is now corrected in
CURLOPT_SSH_KEYFUNCTION.3
@bagder bagder force-pushed the bagder/test1119-complete branch from 75f66f8 to b33c49f Compare Sep 21, 2022
@bagder bagder closed this in 6c951c4 Sep 22, 2022
bagder added a commit that referenced this pull request Sep 22, 2022
bagder added a commit that referenced this pull request Sep 22, 2022
This script now also finds all .3 man pages in docs/include and
docs/include/opts, extracts all uses of CURL* symbols and verifies that all
symbols mentioned in docs are defined in public headers.

A "global symbol" is one of those matching a known prefix and the script makes
an attempt to check all/most of them. Just using *all* symbols that match
CURL* proved matching a little too many other references as well and turned
difficult turning into something useful.

Closes #9544
@bagder bagder deleted the bagder/test1119-complete branch Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant