Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: macOS w/ m1(arm64) for curl build and testing #9565

Closed
wants to merge 3 commits into from

Conversation

pheiduck
Copy link
Contributor

@pheiduck pheiduck commented Sep 21, 2022

normal and debug builds.
more will be added in next PR.

@pheiduck pheiduck marked this pull request as draft Sep 21, 2022
@pheiduck
Copy link
Contributor Author

pheiduck commented Sep 21, 2022

@bagder @mback2k
I need some feedback for this, let me know what you think about this CI implementation.
Thank you! :)

@pheiduck pheiduck force-pushed the cirrus/m1 branch 6 times, most recently from 8c5168c to 7a41a69 Compare Sep 22, 2022
@pheiduck
Copy link
Contributor Author

pheiduck commented Sep 22, 2022

m1 (arm64) complie works now 🎉

@pheiduck pheiduck marked this pull request as ready for review Sep 22, 2022
@pheiduck pheiduck changed the title CI: macOS w/ m1 for curl build and testing CI: macOS w/ m1 for curl build and testing (arm64) Sep 22, 2022
@pheiduck pheiduck changed the title CI: macOS w/ m1 for curl build and testing (arm64) CI: macOS w/ m1(arm64) for curl build and testing Sep 22, 2022
@pheiduck
Copy link
Contributor Author

pheiduck commented Sep 22, 2022

@bagder CI looks good now 👍

@vszakats vszakats added the CI Continuous Integration label Sep 22, 2022
@bagder bagder requested a review from mback2k Sep 23, 2022
@pheiduck
Copy link
Contributor Author

pheiduck commented Sep 23, 2022

@bagder maybe we could also find a workaround for openldap so that we don't have to use the build flags: --disable-ldap --disable-ldaps.

@bagder
Copy link
Member

bagder commented Sep 23, 2022

@bagder maybe we could also find a workaround for openldap so that we don't have to use the build flags: --disable-ldap --disable-ldaps.

What happens if you you remove them?

@pheiduck
Copy link
Contributor Author

pheiduck commented Sep 23, 2022

What happens if you you remove them?

You can see it here: https://cirrus-ci.com/task/5899470490566656
There are some deprecations in ldap.c and ldap.h -> XCode
We could implement a function --without-ldap?

@bagder
Copy link
Member

bagder commented Sep 24, 2022

Ah, I've seen those ldap deprecation warnings on "regular" macOS builds too...

@pheiduck
Copy link
Contributor Author

pheiduck commented Sep 24, 2022

Ah, I've seen those ldap deprecation warnings on "regular" macOS builds too...

It works with: CFLAGS: "-Wno-vla -mmacosx-version-min=10.9" which we use on "regular" macOS builds as well.

@pheiduck
Copy link
Contributor Author

pheiduck commented Sep 24, 2022

Finally let me know if you what some fine tuning. But for now it’s ready for review/merge

.cirrus.yml Outdated Show resolved Hide resolved
.cirrus.yml Outdated Show resolved Hide resolved
.cirrus.yml Outdated Show resolved Hide resolved
@mback2k
Copy link
Member

mback2k commented Sep 24, 2022

Thanks for your contribution @pheiduck. I got some minor comments you may want to look at before this is merged.

@pheiduck pheiduck force-pushed the cirrus/m1 branch 3 times, most recently from 4c059ff to 0160d1b Compare Sep 24, 2022
Signed-off-by: Philip H <47042125+pheiduck@users.noreply.github.com>
@pheiduck
Copy link
Contributor Author

pheiduck commented Sep 24, 2022

Thanks for your contribution @pheiduck. I got some minor comments you may want to look at before this is merged.

@mback2k done. It only fails now because the branch is not in sync with the upstream due to rebase. All problems have been fixed so that the CI runs stable.

@pheiduck
Copy link
Contributor Author

pheiduck commented Sep 24, 2022

And yes we could it also simplify like the windows task, but maybe on a next PR. ;)

@pheiduck pheiduck requested a review from mback2k Sep 25, 2022
Copy link
Member

@mback2k mback2k left a comment

LGTM

@bagder
Copy link
Member

bagder commented Sep 29, 2022

Thanks!

@bagder bagder closed this in 55becae Sep 29, 2022
@pheiduck pheiduck deleted the cirrus/m1 branch Sep 30, 2022
mback2k pushed a commit that referenced this pull request Oct 15, 2022
Also refactor macOS builds to use task matrix.

Assisted-by: Marc Hörsken
Closes #9565
mback2k added a commit to mback2k/curl that referenced this pull request Oct 15, 2022
mback2k added a commit to mback2k/curl that referenced this pull request Oct 17, 2022
Also disable SFTP and SCP tests with libssh2 for now.

Follow up to curl#9565 and curl#9677
mback2k added a commit to mback2k/curl that referenced this pull request Oct 18, 2022
Also disable SFTP and SCP tests with libssh2 for now.

Follow up to curl#9565 and curl#9677
mback2k added a commit to mback2k/curl that referenced this pull request Oct 20, 2022
Also disable SFTP and SCP tests with libssh2 for now.

Follow up to curl#9565 and curl#9677
mback2k added a commit to mback2k/curl that referenced this pull request Oct 24, 2022
Also disable SFTP and SCP tests with libssh2 for now.

Follow up to curl#9565 and curl#9677
mback2k added a commit that referenced this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants