Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable use of FLOSS for 64-bit NonStop builds. #9575

Closed
wants to merge 1 commit into from

Conversation

rsbeckerca
Copy link
Contributor

@rsbeckerca rsbeckerca commented Sep 22, 2022

Older 32-bit builds currently need FLOSS. This dependency may be removed in future OS releases.

Signed-off-by: Randall S. Becker randall.becker@nexbridge.ca

Older 32-bit builds currently need FLOSS. This dependency may be removed
in future OS releases.

Signed-off-by: Randall S. Becker <randall.becker@nexbridge.ca>
@jay
Copy link
Member

jay commented Sep 22, 2022

I can't find anything about this, do you have a reference?

@jay jay added the build label Sep 22, 2022
@rsbeckerca
Copy link
Contributor Author

rsbeckerca commented Sep 22, 2022

@jay The original port was included in 2004 - before I was involved. In those days, there was no 64-bit NonStop OS. As time went by, NonStop moved to ia64 and x86. Parts of the utilities, including FLOSS, which is a bit like glibc, stayed in 32-bit land. The APIs in the NonStop POSIX side have evolved and cover far more than they did in 2004. As a result, for 64-bit builds, FLOSS is rarely needed, and not at all in curl. There are pending build issues we are trying to address for 32-bit code that avoid the need for FLOSS but I am not there yet with the HPE Dev team. As part of moving curl to 64-bit builds, I found that FLOSS not only is not needed, but causes link issues if included, so it has to be removed from all parts of the build. At present, FLOSS only exists in 32-bit form on NonStop, so creating a 64-bit curl with FLOSS is not possible. There is still a need in my community for 32-bit libcurl.a, so that has to be retained and needs FLOSS.

Therefore, the solution, as I see it, is disabling the use of floss.h when a 64-bit build is being done, with the c99 compiler generated knob being __LP64.

bagder
bagder approved these changes Sep 22, 2022
Copy link
Member

@bagder bagder left a comment

Since @rsbeckerca is working on and with this platform, I figure he is the most suitable person to have a say on how this build should be adjusted.

@bagder
Copy link
Member

bagder commented Sep 23, 2022

Thanks!

@bagder bagder closed this in 7801cb9 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants