Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: adjust name/visibility of two internal public functions #9598

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Sep 26, 2022

According to docs/INTERNALS.md, internal function names spanning source files start with uppercase Curl_. Bring these two functions in alignment with this.

This also stops exporting them from libcurl.dll.

Closes #xxxx

According to `docs/INTERNALS.md`, internal function names spanning source
files start with uppercase `Curl_`. Bring these two functions in
alignment with this.

This also stops exporting them from `libcurl.dll`.

Closes #xxxx
@vszakats vszakats added build Windows Windows-specific labels Sep 26, 2022
vszakats added a commit to curl/curl-for-win that referenced this pull request Sep 26, 2022
…ci skip]

Might also apply to CMake.

Since a few commits ago we use cmake and autotools built-in options to
hide non-libcurl symbols (from DLL exports). They (or at least autotools)
rely on the assumption that public libcurl functions start with `curl_`.
These two function started with that though they are internal ones.

Ref: curl/curl#9598
bagder
bagder approved these changes Sep 26, 2022
Copy link
Member

@bagder bagder left a comment

👍

@vszakats vszakats closed this in 92b9624 Sep 26, 2022
@vszakats vszakats deleted the win32-idn-visibility branch Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Windows Windows-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants